Skip Menu |
 

History Show all quoted text — Show full headers
# Mon Dec 16 14:33:42 2013 Andrea Campi <andrea.campi@gmail.com> - Ticket created
From: Andrea Campi <andrea.campi@gmail.com>
Date: Sat, 14 Dec 2013 22:23:19 -0800
Subject: Potential leaks in error paths in acquire_accept_cred
To: krb5-bugs@mit.edu
Download (untitled) / with headers
text/plain 207B
Download (untitled) / with headers
text/html 262B
The error handling if() blocks at lines 227 and 234 of src/lib/gssapi/krb5/acquire_cred.c are missing krb5_kt_close(context, kt);

I don't have a test case, but we noticed while debugging a similar problem. 
# Mon Dec 16 17:17:49 2013 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Mon Dec 16 17:17:49 2013 ghudson@mit.edu (Greg Hudson) - Target_Version 1.12.1 added
# Mon Dec 16 17:17:49 2013 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'
# Mon Dec 16 17:17:49 2013 ghudson@mit.edu (Greg Hudson) - Tags pullup added
# Mon Dec 16 17:17:49 2013 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 630B

Fix GSS krb5 acceptor acquire_cred error handling

When acquiring acceptor creds with a specified name, if we fail to
open a replay cache, we leak the keytab handle. If there is no
specified name and we discover that there is no content in the keytab,
we leak the keytab handle and return the wrong major code. Memory
leak reported by Andrea Campi.

https://github.com/krb5/krb5/commit/decccbcb5075f8fbc28a535a9b337afc84a15dee
Author: Greg Hudson <ghudson@mit.edu>
Commit: decccbcb5075f8fbc28a535a9b337afc84a15dee
Branch: master
src/lib/gssapi/krb5/acquire_cred.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
# Wed Jan 08 22:30:30 2014 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Wed Jan 08 22:30:30 2014 tlyu (Taylor Yu) - Version_Fixed 1.12.1 added
# Wed Jan 08 22:30:30 2014 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 736B

Fix GSS krb5 acceptor acquire_cred error handling

When acquiring acceptor creds with a specified name, if we fail to
open a replay cache, we leak the keytab handle. If there is no
specified name and we discover that there is no content in the keytab,
we leak the keytab handle and return the wrong major code. Memory
leak reported by Andrea Campi.

(cherry picked from commit decccbcb5075f8fbc28a535a9b337afc84a15dee)

https://github.com/krb5/krb5/commit/1407fd928724300376162a1f29035ce8c25be9db
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 1407fd928724300376162a1f29035ce8c25be9db
Branch: krb5-1.12
src/lib/gssapi/krb5/acquire_cred.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
# Wed Dec 16 18:03:01 2015 tlyu (Taylor Yu) - CustomField pullup deleted