Skip Menu |
 

History Show all quoted text — Show full headers
# Fri Dec 20 11:02:34 2013 ghudson@mit.edu (Greg Hudson) - Ticket created
Subject: klist displays bad error for nonexistent KEYRING ccache
Download (untitled) / with headers
text/plain 647B
If the default cache has type KEYRING and does not exist, klist
displays:

klist: No credentials cache found while retrieving principal name

For a FILE ccache, klist displays:

klist: No credentials cache found (ticket cache FILE:/pathname)

This is because file ccaches fail in krb5_cc_set_flags while keyring
ccaches fail in krb5_cc_get_principal.

On a related note, klist doesn't have a com_err hook like kinit, so it
ignores extended error messages. If it did use extended messages, we
would see the extended error message "Credentials cache file '/pathname'
not found (ticket cache FILE:/pathname)", which would be redundant.
# Sat Dec 21 00:05:38 2013 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Sat Dec 21 00:05:38 2013 ghudson@mit.edu (Greg Hudson) - Target_Version 1.12.1 added
# Sat Dec 21 00:05:38 2013 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'review'
# Sat Dec 21 00:05:38 2013 ghudson@mit.edu (Greg Hudson) - Tags pullup added
# Sat Dec 21 00:05:38 2013 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 624B

Set an error message when keyring get_princ fails

When attempting to use a keyring cache that doesn't exist, set an error
message when we fail to read a principal name, as we do when we return
the same error code when using a file ccache.

[ghudson: removed unnecessary check for d->name nullity.]

https://github.com/krb5/krb5/commit/c25fc42e8eac7350209df61e4a7b9960d17755ca
Author: Nalin Dahyabhai <nalin@dahyabhai.net>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: c25fc42e8eac7350209df61e4a7b9960d17755ca
Branch: master
src/lib/krb5/ccache/cc_keyring.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
# Sat Dec 21 00:05:39 2013 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 821B

Use an extended com_err hook in klist

Add an adapted version of extended_com_err_fn from kinit to klist and
use it. In do_ccache(), rely on the ccache type to set a reasonable
message if krb5_cc_set_flags() or krb5_cc_get_principal() fails due to
a nonexistent or unreadable ccache, and don't confuse the user with
the name of the ccache operation that failed.

https://github.com/krb5/krb5/commit/ae027dd69fc80cca549c9198d10afad389f30873
Author: Greg Hudson <ghudson@mit.edu>
Commit: ae027dd69fc80cca549c9198d10afad389f30873
Branch: master
src/clients/klist/klist.c | 35 ++++++++++++++++-----------------
src/tests/dejagnu/config/default.exp | 2 +-
src/tests/gssapi/t_client_keytab.py | 2 +-
src/tests/t_ccache.py | 6 ++--
4 files changed, 22 insertions(+), 23 deletions(-)
# Wed Jan 08 22:30:35 2014 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 689B

Set an error message when keyring get_princ fails

When attempting to use a keyring cache that doesn't exist, set an error
message when we fail to read a principal name, as we do when we return
the same error code when using a file ccache.

[ghudson: removed unnecessary check for d->name nullity.]

(cherry picked from commit c25fc42e8eac7350209df61e4a7b9960d17755ca)

https://github.com/krb5/krb5/commit/5571685ec73f95cc8d490986f7b87fccd34897f5
Author: Nalin Dahyabhai <nalin@dahyabhai.net>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 5571685ec73f95cc8d490986f7b87fccd34897f5
Branch: krb5-1.12
src/lib/krb5/ccache/cc_keyring.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
# Wed Jan 08 22:30:36 2014 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Wed Jan 08 22:30:36 2014 tlyu (Taylor Yu) - Version_Fixed 1.12.1 added
# Wed Jan 08 22:30:36 2014 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 927B

Use an extended com_err hook in klist

Add an adapted version of extended_com_err_fn from kinit to klist and
use it. In do_ccache(), rely on the ccache type to set a reasonable
message if krb5_cc_set_flags() or krb5_cc_get_principal() fails due to
a nonexistent or unreadable ccache, and don't confuse the user with
the name of the ccache operation that failed.

(cherry picked from commit ae027dd69fc80cca549c9198d10afad389f30873)

https://github.com/krb5/krb5/commit/23ffdc3b87655f12018e4de935263e0ef40cb7b8
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 23ffdc3b87655f12018e4de935263e0ef40cb7b8
Branch: krb5-1.12
src/clients/klist/klist.c | 35 ++++++++++++++++-----------------
src/tests/dejagnu/config/default.exp | 2 +-
src/tests/gssapi/t_client_keytab.py | 2 +-
src/tests/t_ccache.py | 6 ++--
4 files changed, 22 insertions(+), 23 deletions(-)
# Wed Dec 16 18:03:01 2015 tlyu (Taylor Yu) - CustomField pullup deleted