Skip Menu |
 

History Show all quoted text — Show full headers
# Fri Jun 27 22:37:18 2014 ghudson@mit.edu (Greg Hudson) - Ticket created
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 802B

Add a family-independent bindresvport_sa function

This functions allows you to pass IPv4 and IPv6 addresses. If no
address is given, t will determine the family by checking the socket
with getsockname.

[ghudson@mit.edu: clarified commit message, split out setport helper,
squashed with next commit, minimized code changes from old
bindresvport, used socket-utils.h helpers]

https://github.com/krb5/krb5/commit/0d04b60d159ab83b943e43802b1449a3b074bc83
Author: Andreas Schneider <asn@samba.org>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 0d04b60d159ab83b943e43802b1449a3b074bc83
Branch: master
src/include/gssrpc/rename.h | 1 +
src/include/gssrpc/rpc.h | 1 +
src/lib/rpc/bindresvport.c | 34 +++++++++++++++++++++++-----------
3 files changed, 25 insertions(+), 11 deletions(-)
# Fri Jun 27 22:37:18 2014 ghudson@mit.edu (Greg Hudson) - Requestor ghudson@mit.edu (Greg Hudson) added
# Fri Jun 27 22:37:18 2014 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'
# Fri Jun 27 22:37:19 2014 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 975B

Use binresvport_sa when creating RPC handles

Make clnttcp_create, clntudp_bufcreate, svctcp_create, and
svcudp_bufcreate work with unbound IPv6 sockets using bindresvport_sa
and other socket helpers. For caller-supplied sockets, call
getsockname to determine the address family we should attempt to bind.

[ghudson@mit.edu: clarified commit message, minimized code changes,
used socket-utils.h helpers, fixed fallback find on bindresvport
failure, restored getsockaddr call to get port after binding]

https://github.com/krb5/krb5/commit/b272744422dea77fdf9518a20386660df7a97bf7
Author: Andreas Schneider <asn@samba.org>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: b272744422dea77fdf9518a20386660df7a97bf7
Branch: master
src/lib/rpc/clnt_tcp.c | 2 +-
src/lib/rpc/clnt_udp.c | 2 +-
src/lib/rpc/svc_tcp.c | 31 ++++++++++++++++++-------------
src/lib/rpc/svc_udp.c | 31 +++++++++++++++++++------------
4 files changed, 39 insertions(+), 27 deletions(-)
# Wed Jul 02 17:17:56 2014 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 640B

Fix bugs in bindresvport_sa() changes

In svctcp_create() and svcudp_bufcreate(), set sa->sa_len on platforms
where that field exists, so that a subsequent call to socklen() will
return the correct result.

To make the code more self-evidently correct, zero the entire struct
sockaddr_storage object, using the memset(&ss, 0, sizeof(ss)) idiom.

https://github.com/krb5/krb5/commit/158a551b14b017d232066c4a053dc608d87fa172
Author: Tom Yu <tlyu@mit.edu>
Commit: 158a551b14b017d232066c4a053dc608d87fa172
Branch: master
src/lib/rpc/svc_tcp.c | 5 ++++-
src/lib/rpc/svc_udp.c | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
# Tue Jul 15 21:41:06 2014 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 519B

Remove copyright statement added to bindresvport.c

Andreas's copyright statement was added to the Oracle license
statement by mistake; the code changes made to turn bindresvport into
bindresvport_sa are minimal. Remove it with Andreas's permission.

https://github.com/krb5/krb5/commit/e7e0875cd9215db38d7d3e24745780f0712b1ecb
Author: Greg Hudson <ghudson@mit.edu>
Commit: e7e0875cd9215db38d7d3e24745780f0712b1ecb
Branch: master
src/lib/rpc/bindresvport.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
# Tue Aug 12 18:27:39 2014 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Tue Aug 12 18:27:39 2014 tlyu (Taylor Yu) - Version_Fixed 1.13 added