Ticket History #7973: Bad calloc test in krb5_authdata_context

# Fri Jul 18 14:19:18 2014 wfiveash (Will Fiveash) - Ticket created

Subject:

Bad calloc test in krb5_authdata_context_init()

Download (untitled) / with headers
text/plain 179B

In krb5_authdata_context_init() I see:

context = calloc(1, sizeof(*context));
if (kcontext == NULL) {
code = ENOMEM;
goto cleanup;
}

Seems wrong, no?

# Fri Jul 18 14:57:42 2014 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 41B

Yes; I filed pull request #176 to fix it.

# Fri Jul 18 16:01:56 2014 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Fri Jul 18 16:01:56 2014 ghudson@mit.edu (Greg Hudson) - Target_Version 1.12.2 added

# Fri Jul 18 16:01:56 2014 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'

# Fri Jul 18 16:01:56 2014 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Fri Jul 18 16:01:56 2014 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 317B

Fix calloc check in krb5_authdata_context_init

https://github.com/krb5/krb5/commit/4abfd7bc3819a66f77a1cf121b7608af624ecb6e
Author: Greg Hudson <ghudson@mit.edu>
Commit: 4abfd7bc3819a66f77a1cf121b7608af624ecb6e
Branch: master
src/lib/krb5/krb/authdata.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

# Mon Jul 21 18:33:45 2014 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Mon Jul 21 18:33:45 2014 tlyu (Taylor Yu) - Version_Fixed 1.12.2 added

# Mon Jul 21 18:33:45 2014 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 423B

Fix calloc check in krb5_authdata_context_init

(cherry picked from commit 4abfd7bc3819a66f77a1cf121b7608af624ecb6e)

https://github.com/krb5/krb5/commit/6f99ee3aa458443b9ca4722c2aab82db1400bbbf
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 6f99ee3aa458443b9ca4722c2aab82db1400bbbf
Branch: krb5-1.12
src/lib/krb5/krb/authdata.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

# Wed Dec 16 18:03:02 2015 tlyu (Taylor Yu) - CustomField pullup deleted

Ticket History #7973: Bad calloc test in krb5_authdata_context_init()