Skip Menu |

Subject: git commit
Download (untitled) / with headers
text/plain 1.1KiB

Fix error checking in PKINIT authdata creation

In create_identifiers_from_stack: check for allocation errors from
PKCS7_ISSUER_AND_SERIAL_free to more concisely clean up the OpenSSL
issuer variable, and make sure that any partially processed value is
cleaned up on error. Use calloc to allocate krb5_cas so that all of
its pointers are initially nulled, so that
free_krb5_external_principal_identifier can operate on it safely in
case of error. Eliminate the retval variable as it was not used
safely. Rename the error label from "cleanup" to "oom" and separate
it from the successful return path (which has nothing to clean up).

(back ported from commit 09246e64e20f079bef6163e9e1d0ecda7917b8c2)
(cherry picked from commit 62c9e504261a07b8da297854c9fc9549acecc7d3)
Author: Greg Hudson <>
Committer: Tom Yu <>
Commit: 384120086cb68e1588176a2056425c912c169575
Branch: krb5-1.11
src/plugins/preauth/pkinit/pkinit_crypto_openssl.c | 51 +++++++++----------
1 files changed, 24 insertions(+), 27 deletions(-)