Skip Menu |
 

Date: Sat, 28 Mar 2015 10:06:59 -0400
From: John Devitofranceschi <jdvf@optonline.net>
Subject: python test issues
To: krb5-bugs@mit.edu
This seems trivial but...

The shebang line for the following files in src/tests is not the first line in the file. This breaks the tests when
trying to run them individually.

t_ccache.py
t_renprinc.py
t_stringattr.py

Also, most of the .py files are not executable and they probably should be.

This is useful when trying to run the scripts individually (in verbose mode) w/out having to explicitly running them using 'python' on the command line.

jd
From: Tom Yu <tlyu@mit.edu>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #8163] python test issues
Date: Sat, 28 Mar 2015 16:00:01 -0400
RT-Send-Cc:
For the shebang lines, we should either eliminate the shebang lines
altogether or fix those three files so the shebang lines come first.
(The places where the shebang line doesn't come first seem to be due to
copyright notices being at the very top of the file.)

Only two of the .py files in that directory have execute permissions,
which is OK for in-tree use. (We explicitly invoke the python
interpreter.) It does raise the question of whether we should have the
shebang lines at all.
From: ghudson@mit.edu
Subject: git commit

Make all Python test scripts executable

For the convenience of developers manually running Python test
scripts, set the executable bits on all of them, and make sure the
first line is always "#!/usr/bin/python".

https://github.com/krb5/krb5/commit/b97b84de1a83bf615853facd42bfafab267e2e06
Author: Greg Hudson <ghudson@mit.edu>
Commit: b97b84de1a83bf615853facd42bfafab267e2e06
Branch: master
src/appl/gss-sample/t_gss_sample.py | 3 ++-
src/tests/gssapi/t_ccselect.py | 3 ++-
src/tests/t_ccache.py | 3 ++-
src/tests/t_renprinc.py | 3 ++-
src/tests/t_stringattr.py | 3 ++-
src/util/gss-kernel-lib/t_kgss.py | 3 ++-
6 files changed, 12 insertions(+), 6 deletions(-)