Ticket History #8221: Fail during configure if stdint.h missing

# Fri Jul 24 18:11:16 2015 Philip Brown <phil@bolthole.com> - Ticket created

Date:	Fri, 24 Jul 2015 15:06:56 -0700
Subject:	patch for stdint.h
From:	Philip Brown <phil@bolthole.com>
To:	krb5-bugs@mit.edu

Download (untitled) / with headers
text/plain 269B

Certain older systems have difficulty compiling 5-1.13, solely because
they dont have stdint.h

The thing is, GNU autoconf already has hooks for this sort of thing,
but the code isnt using them.

Attached is a patch to make the code take proper advantage of autoconf.h

Download kerb5.1.13.diffs
application/octet-stream 5KiB

Message body not shown because it is not plain text.

# Fri Jul 24 19:01:31 2015 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'open'

# Fri Jul 24 19:01:31 2015 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 444B

The attached patch uses autoconf macros in public headers (krb5.h and
gssapii.h), which doesn't work when those headers are included from
other programs.

We made a deliberate decision to make stdint.h a platform requirement
for 1.13; see
http://mailman.mit.edu/pipermail/krbdev/2014-February/011886.html .

If there are affected platforms besides the ones Russ mentioned in his
follow-up to that message, we would be interested to hear it.

# Fri Jul 24 19:23:55 2015 Philip Brown <phil@bolthole.com> - Correspondence added

Date:	Fri, 24 Jul 2015 16:23:54 -0700
Subject:	Re: [krbdev.mit.edu #8221] AutoReply: patch for stdint.h
From:	Philip Brown <phil@bolthole.com>
To:	rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 706B

oops. I missed a patchfile, and there is a side issue

attached should be the missing patch for src/util/t_array.pm

However, I have noticed that my patch for include/krb5.hin is not sufficient.
It allows for the compiled libs. However, it has the problem that it
will not cleanly work for a fully standalone, installed set of kerb
headers.
It will, post installation, leave an include/krb5 file, that will only
properly work if either
HAVE_STDINT_H or
HAVE_INTTYPES_H
is defined.

What should really be done is to either
a) preprocess the hin file to directly iinclude the line
or
b) include the autoconf.h definitions in the post "make install" headers?

I'm not sure how to do either of those cleanly.

Download kerb5.1.13.diff2
application/octet-stream 373B

Message body not shown because it is not plain text.

# Fri Jul 24 19:37:53 2015 Philip Brown <phil@bolthole.com> - Comments added

Date:	Fri, 24 Jul 2015 16:37:52 -0700
Subject:	Re: [krbdev.mit.edu #8221] patch for stdint.h
From:	Philip Brown <phil@bolthole.com>
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 459B

oh.
thats annoying.

i guess it's somewhat understandable. But in that case, would you
please fix the autoconf to actually bomb out, rather than to do its
default thing and just silently undefine HAS_STDINT_H in autoconf.h

?

I dont know the "nice" autoconf way of doing that.
However, an alternative way of achieving a similar result, could be
patching include/k5-platform.h to have,

#ifndef HAS_STDINT_H
#error stdint.h is now required by kerberos
#endif

# Fri Jul 24 19:37:53 2015 Philip Brown <phil@bolthole.com> - Correspondence added

Date:	Fri, 24 Jul 2015 16:37:52 -0700
Subject:	Re: [krbdev.mit.edu #8221] patch for stdint.h
From:	Philip Brown <phil@bolthole.com>
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 459B

oh.
thats annoying.

i guess it's somewhat understandable. But in that case, would you
please fix the autoconf to actually bomb out, rather than to do its
default thing and just silently undefine HAS_STDINT_H in autoconf.h

?

I dont know the "nice" autoconf way of doing that.
However, an alternative way of achieving a similar result, could be
patching include/k5-platform.h to have,

#ifndef HAS_STDINT_H
#error stdint.h is now required by kerberos
#endif

# Fri Jul 24 19:39:19 2015 Philip Brown <phil@bolthole.com> - Correspondence added

Date:	Fri, 24 Jul 2015 16:39:18 -0700
Subject:	Re: [krbdev.mit.edu #8221] patch for stdint.h
From:	Philip Brown <phil@bolthole.com>
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 207B

PS: the platform I'm working on, is indeed not mentioned in
http://mailman.mit.edu/pipermail/krbdev/2014-February/011887.html

it is Solaris 9.

but again, it is ancient, so you probably dont care anyway :(

# Fri Jul 24 19:39:19 2015 Philip Brown <phil@bolthole.com> - Comments added

Date:	Fri, 24 Jul 2015 16:39:18 -0700
Subject:	Re: [krbdev.mit.edu #8221] patch for stdint.h
From:	Philip Brown <phil@bolthole.com>
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 207B

PS: the platform I'm working on, is indeed not mentioned in
http://mailman.mit.edu/pipermail/krbdev/2014-February/011887.html

it is Solaris 9.

but again, it is ancient, so you probably dont care anyway :(

# Mon Sep 21 17:12:56 2015 tlyu (Taylor Yu) - Taken

# Mon Sep 21 18:33:39 2015 tlyu (Taylor Yu) - Target_Version 1.14 added

# Mon Sep 21 18:33:39 2015 tlyu (Taylor Yu) - Status changed from 'open' to 'review'

# Mon Sep 21 18:33:39 2015 tlyu (Taylor Yu) - Tags pullup added

# Mon Sep 21 18:33:39 2015 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 406B

Fail during configure if stdint.h missing

We now require stdint.h to build this software. Gracefully fail
during configure time if stdint.h is missing.

https://github.com/krb5/krb5/commit/33441e6376d5b1606089a3621798493027816010
Author: Tom Yu <tlyu@mit.edu>
Commit: 33441e6376d5b1606089a3621798493027816010
Branch: master
src/configure.in | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

# Thu Sep 24 07:46:53 2015 tlyu (Taylor Yu) - Subject changed from 'patch for stdint.h' to 'Fail during configure if stdint.h missing'

# Fri Oct 02 14:19:27 2015 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Fri Oct 02 14:19:27 2015 tlyu (Taylor Yu) - Version_Fixed 1.14 added

# Fri Oct 02 14:19:27 2015 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 479B

Fail during configure if stdint.h missing

We now require stdint.h to build this software. Gracefully fail
during configure time if stdint.h is missing.

(cherry picked from commit 33441e6376d5b1606089a3621798493027816010)

https://github.com/krb5/krb5/commit/8ba3d5790c8065e65eaff10f89a5c9ea7c809b68
Author: Tom Yu <tlyu@mit.edu>
Commit: 8ba3d5790c8065e65eaff10f89a5c9ea7c809b68
Branch: krb5-1.14
src/configure.in | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

# Wed Dec 16 18:03:03 2015 tlyu (Taylor Yu) - CustomField pullup deleted