Ticket History #8267: unsetenv() returns void

# Sun Oct 04 19:40:09 2015 Thomas Bernard <thomas.bernard@cls.to> - Ticket created

Date:	Sun, 4 Oct 2015 22:45:21 +0200
Subject:	unsetenv() returns void
From:	Thomas Bernard <thomas.bernard@cls.to>
To:	krb5-bugs@mit.edu

Download (untitled) / with headers
text/plain 781B

Hello,

I've been trying to build krb5 1.13.2 on my old G4 Power Mac (PPC)
with OS X 10.4.11
I've got the following error in clients/ksu/main.c :
main.c: In function "get_configured_defccname":
main.c:818: error: void value not ignored as it ought to be
*** [main.o] Error 1

indeed, unsetenv() returns void (OS X 10.4) :
man 3 unsetenv
...
void
unsetenv(const char *name);
...
HISTORY
The functions setenv() and unsetenv() appeared in Version 7 AT&T UNIX.

Show quoted text

>From a recent linux man :

Prior to glibc 2.2.2, unsetenv() was prototyped as returning void;
more recent glibc versions follow the POSIX.1-2001-compliant prototype
shown in the SYNOPSIS.

regards,
--

Thomas Bernard - thomas.bernard@cls.to
Conseil Logiciel Securite SAS
1 Passage du Surmelin
75020 Paris

Download void_unsetenv_PPC_Tiger_.patch
application/octet-stream 596B

Message body not shown because it is not plain text.

# Sun Oct 04 19:41:47 2015 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'open'

# Sun Oct 04 19:41:47 2015 ghudson@mit.edu (Greg Hudson) - Comments added

Download (untitled) / with headers
text/plain 165B

ksu also contains a compatibility definition of unsetenv() which
returns void. We should change the use in get_configured_defccname()
to not use the return value.

# Fri Oct 23 12:06:08 2015 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Fri Oct 23 12:06:08 2015 ghudson@mit.edu (Greg Hudson) - Target_Version 1.14 added

# Fri Oct 23 12:06:08 2015 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'review'

# Fri Oct 23 12:06:08 2015 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Fri Oct 23 12:06:08 2015 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 510B

Make ksu work when unsetenv() returns NULL

Some older platforms (OS X 10.4, glibc 2.2.1) declare unsetenv() as
returning void, as does ksu's compatibility definition of unsetenv().
Don't use the return value in get_configured_defccname().

https://github.com/krb5/krb5/commit/7eee546db10e907666e02fdded4f512e8d0faf4c
Author: Greg Hudson <ghudson@mit.edu>
Commit: 7eee546db10e907666e02fdded4f512e8d0faf4c
Branch: master
src/clients/ksu/main.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)

# Mon Oct 26 15:39:37 2015 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Mon Oct 26 15:39:37 2015 tlyu (Taylor Yu) - Version_Fixed 1.14 added

# Mon Oct 26 15:39:37 2015 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 616B

Make ksu work when unsetenv() returns NULL

Some older platforms (OS X 10.4, glibc 2.2.1) declare unsetenv() as
returning void, as does ksu's compatibility definition of unsetenv().
Don't use the return value in get_configured_defccname().

(cherry picked from commit 7eee546db10e907666e02fdded4f512e8d0faf4c)

https://github.com/krb5/krb5/commit/83ef046b405dfad26538eeccc117e1ab178bdd91
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 83ef046b405dfad26538eeccc117e1ab178bdd91
Branch: krb5-1.14
src/clients/ksu/main.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)

# Wed Dec 16 18:03:04 2015 tlyu (Taylor Yu) - CustomField pullup deleted