Skip Menu |
 

Subject: Audit Test fails when system has IPV6 address
The jsonwalker audit test fails when the machine has an IPV6 address
because the fromaddr.ipv4 field is missing.
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 1.2KiB

Add IPv6 address logging support to audit plugin

The jsonwalker.py test was failing due to the audit plugin only
logging the IP for IPv4. The audit plugin should log the IP address
for both IPv4 and IPv6. Rename the JSON "ipv4" field in the
"fromaddr" JSON object to "ip" and set the field if either an IPv4 or
an IPv6 address is present. Any parsers of the audit log can tell
which address is stored in the "ip" field by checking the "type" field
in "fromaddr". Also update the jsonwalker.py reference JSON file,
au_dict.json, to handle this new field name.

old audit:

{"fromaddr":{"type":<int>,"length":<int>,"ipv4":[<4 int>]}

where "ipv4" only occurs when type is ADDRTYPE_INET

new audit:

{"fromaddr":{"type":<int>,"length":<int>,"ip":[<<length> int>]}

where "ip" only occurs when type is ADDRTYPE_INET or ADDRTYPE_INET6

[tlyu@mit.edu: minor commit message edits]

https://github.com/krb5/krb5/commit/5e063638032912f93df1426dc92cdae5e65c5e5a
Author: Sarah Day <sarahday@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 5e063638032912f93df1426dc92cdae5e65c5e5a
Branch: master
src/plugins/audit/j_dict.h | 2 +-
src/plugins/audit/kdc_j_encode.c | 4 ++--
src/tests/au_dict.json | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)