Skip Menu |
 

History Show all quoted text — Show full headers
# Thu Dec 10 20:19:35 2015 wfiveash (Will Fiveash) - Ticket created
Subject: hostrealm code won't compile in debug mode using Solaris Studio C
Download (untitled) / with headers
text/plain 900B
When I compile MIT v1.13.2 code using debug compile options and the
solaris studio v12.4 C compiler I see:

+ /opt/SUNWspro/solarisstudio12.4/bin/cc -m32 -g '-xchip=pentium'
'-xregs=no%frameptr' -mt -D_LARGEFILE_SOURCE '-D_FILE_OFFSET_BITS=64'
-KPIC -DPIC -dy -G -z text -h hostrealm_test.so.0 -o hostrealm_test.so
main.so -R/usr/lib -L../../../lib -lkrb5 -lc -z defs
Undefined first referenced
symbol in file
krb5int_zap main.so (symbol belongs to implicit
dependency ../../../lib/libkrb5support.so.0)
ld: fatal: symbol referencing errors

Modifying the krb5-1.13.2/src/plugins/hostrealm/test/Makefile.in file so
this:

SHLIB_EXPDEPS= $(KRB5_DEPLIB)
SHLIB_EXPLIBS= $(KRB5_LIB)

becomes:
SHLIB_EXPDEPS= $(KRB5_DEPLIB) $(SUPPORT_DEPLIB)
SHLIB_EXPLIBS= $(KRB5_LIB) $(SUPPORT_LIB)

fixes the undefined krb5int_zap symbol issue.
# Fri Dec 11 10:44:57 2015 ghudson@mit.edu (Greg Hudson) - Correspondence added
Download (untitled) / with headers
text/plain 109B
Do you have any idea where in main.c the zap dependency is coming from?
I don't see any obvious candidates.
# Fri Dec 11 10:57:53 2015 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'open'
# Fri Dec 11 10:57:53 2015 ghudson@mit.edu (Greg Hudson) - Correspondence added
Download (untitled) / with headers
text/plain 244B
Ah, I forgot that the Solaris compiler builds static inline functions
and creates dependencies even if they aren't used. So the dependency
just comes from zapfree() and zapfreestr() in k5-int.h. I will make a
pull request with this change.
# Fri Dec 11 12:45:38 2015 <will.fiveash@oracle.com> - Correspondence added
Date: Fri, 11 Dec 2015 11:45:34 -0600
From: Will Fiveash <will.fiveash@oracle.com>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #8326] hostrealm code won't compile in debug mode using Solaris Studio C
RT-Send-Cc:
Download (untitled) / with headers
text/plain 461B
On Fri, Dec 11, 2015 at 10:57:53AM -0500, Greg Hudson via RT wrote:
Show quoted text
> Ah, I forgot that the Solaris compiler builds static inline functions
> and creates dependencies even if they aren't used. So the dependency
> just comes from zapfree() and zapfreestr() in k5-int.h. I will make a
> pull request with this change.

Yeah, that's what I'm seeing with the Solaris Studio compiler. Thanks
for fixing this.

--
Will Fiveash
Oracle Solaris Software Engineer
# Wed Dec 16 13:04:34 2015 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Wed Dec 16 13:04:34 2015 ghudson@mit.edu (Greg Hudson) - Target_Version 1.14-next added
# Wed Dec 16 13:04:34 2015 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'review'
# Wed Dec 16 13:04:34 2015 ghudson@mit.edu (Greg Hudson) - Tags pullup added
# Wed Dec 16 13:04:34 2015 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 824B

Add libkrb5support dependencies to test plugins

In some build environments, dependencies on libkrb5support can be
generated just from static inline functions in our header files, even
if those functions aren't used. In two test plugin modules, use
$(KRB5_BASE_DEPLIBS) and $(KRB5_BASE_LIBS) to depend on libkrb5support
as well as libkrb5. (This also pulls in libk5crypto, which is
unnecessary for these modules, but is inconsequential for a test
module.) Reported by Will Fiveash.

https://github.com/krb5/krb5/commit/5568d31f45fb78f505340a5b520b22d4dd3f6522
Author: Greg Hudson <ghudson@mit.edu>
Commit: 5568d31f45fb78f505340a5b520b22d4dd3f6522
Branch: master
src/plugins/hostrealm/test/Makefile.in | 6 +++---
src/plugins/pwqual/test/Makefile.in | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
# Wed Dec 16 18:08:53 2015 tlyu (Taylor Yu) - Target_Version 1.13-next added
# Thu Dec 17 15:44:20 2015 tlyu (Taylor Yu) - Version_Fixed 1.14.1 added
# Thu Dec 17 15:44:20 2015 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 930B

Add libkrb5support dependencies to test plugins

In some build environments, dependencies on libkrb5support can be
generated just from static inline functions in our header files, even
if those functions aren't used. In two test plugin modules, use
$(KRB5_BASE_DEPLIBS) and $(KRB5_BASE_LIBS) to depend on libkrb5support
as well as libkrb5. (This also pulls in libk5crypto, which is
unnecessary for these modules, but is inconsequential for a test
module.) Reported by Will Fiveash.

(cherry picked from commit 5568d31f45fb78f505340a5b520b22d4dd3f6522)

https://github.com/krb5/krb5/commit/5e3902de9753bb86488ee04abc886a3d51261653
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 5e3902de9753bb86488ee04abc886a3d51261653
Branch: krb5-1.14
src/plugins/hostrealm/test/Makefile.in | 6 +++---
src/plugins/pwqual/test/Makefile.in | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
# Fri Dec 18 13:40:21 2015 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Fri Dec 18 13:40:22 2015 tlyu (Taylor Yu) - Version_Fixed 1.13.4 added
# Fri Dec 18 13:53:25 2015 tlyu (Taylor Yu) - CustomField pullup deleted