Skip Menu |
 

History Show all quoted text — Show full headers
# Wed Feb 17 17:53:06 2016 wfiveash (Will Fiveash) - Ticket created
Subject: s4u protocol transition tests revealing memleaks in krb5kdc
Download (untitled) / with headers
text/plain 2.2KiB
I'm seeing a number of memory leaks affecting krb5kdc when the t_s4u.py
test is run. Here are the typical leaked memory allocation stacks:

umem_alloc_112 leak: 12 buffers, 112 bytes each, 1344 bytes total
ADDR BUFADDR TIMESTAMP THREAD
CACHE LASTLOG CONTENTS
cfeef635f0 cfeef60fd0 4e024ede49f9ab 1
cfeee3c028 cfeec41b00 0
libumem.so.1`umem_cache_alloc+0x158
libumem.so.1`umem_alloc+0x70
libumem.so.1`malloc+0x24
libumem.so.1`calloc+0x44
db2.so`krb5_decode_princ_entry+0xc
db2.so`krb5_db2_get_principal+0xf8
db2.so`wrap_krb5_db2_get_principal+0x34
libkdb5.so.8.0`krb5_db_get_principal+0x50
kdc_get_server_key+0x58
process_tgs_req+0x75c
dispatch+0x298
krb5kdc`process_tcp_connection_read+0x21c
libverto.so.0.0`verto_fire+0x28
libverto.so.0.0`k5ev_invoke_pending+0x54
libverto.so.0.0`k5ev_run+0x464

and

umem_alloc_64 leak: 12 buffers, 64 bytes each, 768 bytes total
ADDR BUFADDR TIMESTAMP THREAD
CACHE LASTLOG CONTENTS
cfeef1feb0 cfeef1af80 4e024ede4a1210 1
cfeee2e028 cfeec41bc0 0
libumem.so.1`umem_cache_alloc+0x228
libumem.so.1`umem_alloc+0x70
libumem.so.1`malloc+0x24
libumem.so.1`calloc+0x44
libkrb5.so.3.3`allocate_princ+0x10
libkrb5.so.3.3`krb5_parse_name_flags+0x30
db2.so`krb5_decode_princ_entry+0x368
db2.so`krb5_db2_get_principal+0xf8
db2.so`wrap_krb5_db2_get_principal+0x34
libkdb5.so.8.0`krb5_db_get_principal+0x50
kdc_get_server_key+0x58
process_tgs_req+0x75c
dispatch+0x298
krb5kdc`process_tcp_connection_read+0x21c
libverto.so.0.0`verto_fire+0x28

I've attached the full memleak report.
Download memleaks.out
application/octet-stream 16.4KiB

Message body not shown because it is not plain text.

# Tue Mar 01 16:41:01 2016 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Tue Mar 01 16:41:01 2016 ghudson@mit.edu (Greg Hudson) - Target_Version 1.13-next added
# Tue Mar 01 16:41:01 2016 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'
# Tue Mar 01 16:41:01 2016 ghudson@mit.edu (Greg Hudson) - Tags pullup added
# Tue Mar 01 16:41:01 2016 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 442B

Fix KDC memory leak on failed S4U2Proxy requests

Make sure to release stkt_server in process_tgs_req() if we fail
before its disposition is determined. Reported by Will Fiveash.

https://github.com/krb5/krb5/commit/194641a8ad7aecc6bc1d4848742c14569f14b900
Author: Greg Hudson <ghudson@mit.edu>
Commit: 194641a8ad7aecc6bc1d4848742c14569f14b900
Branch: master
src/kdc/do_tgs_req.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
# Tue Mar 01 16:41:47 2016 ghudson@mit.edu (Greg Hudson) - Target_Version 1.14-next added
# Tue Apr 05 23:02:56 2016 tlyu (Taylor Yu) - Version_Fixed 1.14.2 added
# Tue Apr 05 23:02:56 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 548B

Fix KDC memory leak on failed S4U2Proxy requests

Make sure to release stkt_server in process_tgs_req() if we fail
before its disposition is determined. Reported by Will Fiveash.

(cherry picked from commit 194641a8ad7aecc6bc1d4848742c14569f14b900)

https://github.com/krb5/krb5/commit/8c505c46f4ebce10adae7e1ba671a3ec6abd5e39
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 8c505c46f4ebce10adae7e1ba671a3ec6abd5e39
Branch: krb5-1.14
src/kdc/do_tgs_req.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
# Wed Apr 06 14:07:11 2016 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Wed Apr 06 14:07:11 2016 tlyu (Taylor Yu) - Version_Fixed 1.13.5 added
# Wed Apr 06 14:07:11 2016 tlyu (Taylor Yu) - CustomField pullup deleted
# Wed Apr 06 14:07:11 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 546B

Fix KDC memory leak on failed S4U2Proxy requests

Make sure to release stkt_server in process_tgs_req() if we fail
before its disposition is determined. Reported by Will Fiveash.

(back ported from commit 194641a8ad7aecc6bc1d4848742c14569f14b900)

https://github.com/krb5/krb5/commit/c16a6bb0de6b09319d8bb80b04c5bf87b31798f2
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: c16a6bb0de6b09319d8bb80b04c5bf87b31798f2
Branch: krb5-1.13
src/kdc/do_tgs_req.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)