Ticket History #8421: Avoid setting AS key when OTP preauth fails

# Thu May 26 18:24:43 2016 ghudson@mit.edu (Greg Hudson) - Ticket created

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 675B

Avoid setting AS key when OTP preauth fails

In otp_client_process(), call cb->set_as_key() later in the function
after the OTP request has been created. The previous position of this
call caused the AS key to be replaced even when later code in the
function failed, preventing other preauth mechanisms from retrieving
the correct AS key.

https://github.com/krb5/krb5/commit/0712d0059d72ddeaf1764f8fa173a321e3bc072d
Author: Nathaniel McCallum <npmccallum@redhat.com>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 0712d0059d72ddeaf1764f8fa173a321e3bc072d
Branch: master
src/lib/krb5/krb/preauth_otp.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

# Thu May 26 18:24:43 2016 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'

# Thu May 26 18:24:43 2016 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Thu May 26 18:24:43 2016 ghudson@mit.edu (Greg Hudson) - Requestor ghudson@mit.edu (Greg Hudson) added

# Wed Jul 06 16:30:45 2016 tlyu (Taylor Yu) - Version_Fixed 1.14.3 added

# Wed Jul 06 16:30:45 2016 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 740B

Avoid setting AS key when OTP preauth fails

In otp_client_process(), call cb->set_as_key() later in the function
after the OTP request has been created. The previous position of this
call caused the AS key to be replaced even when later code in the
function failed, preventing other preauth mechanisms from retrieving
the correct AS key.

(cherry picked from commit 0712d0059d72ddeaf1764f8fa173a321e3bc072d)

https://github.com/krb5/krb5/commit/75bb0f2c25ea78bef97e95fd6086d8b5c205d224
Author: Nathaniel McCallum <npmccallum@redhat.com>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 75bb0f2c25ea78bef97e95fd6086d8b5c205d224
Branch: krb5-1.14
src/lib/krb5/krb/preauth_otp.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

# Wed Jul 06 16:32:58 2016 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Wed Jul 06 16:32:58 2016 tlyu (Taylor Yu) - Version_Fixed 1.13.6 added

# Wed Jul 06 16:32:58 2016 tlyu (Taylor Yu) - CustomField pullup deleted

# Wed Jul 06 16:32:58 2016 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 740B

Avoid setting AS key when OTP preauth fails

In otp_client_process(), call cb->set_as_key() later in the function
after the OTP request has been created. The previous position of this
call caused the AS key to be replaced even when later code in the
function failed, preventing other preauth mechanisms from retrieving
the correct AS key.

(cherry picked from commit 0712d0059d72ddeaf1764f8fa173a321e3bc072d)

https://github.com/krb5/krb5/commit/c82185d4b62cb943d47f90d93f4e51d0dd184d18
Author: Nathaniel McCallum <npmccallum@redhat.com>
Committer: Tom Yu <tlyu@mit.edu>
Commit: c82185d4b62cb943d47f90d93f4e51d0dd184d18
Branch: krb5-1.13
src/lib/krb5/krb/preauth_otp.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)