Skip Menu |
 

History Show all quoted text — Show full headers
# Sat May 28 20:12:24 2016 Shawn Emery <shawn.emery@oracle.com> - Ticket created
From: Shawn M Emery <shawn.emery@oracle.com>
To: krb5-bugs@mit.edu
Subject: New failure in t_sn2princ.py
Date: Sat, 28 May 2016 00:53:48 -0600
Download (untitled) / with headers
text/plain 839B

It looks like there were some changes in the kerberos.org domain in the
past week, which causes regression test failure:
...
src/tests/t_sn2princ.py no
*** Failure: Expected SVC/kerberos-org.mit.edu@R3, got
SVC/kerborg-app-1.mit.edu@R3

And indeed the PTR RR is now pointing to kerborg-app-1.mit.edu:

49.62.9.18.in-addr.arpa name = kerborg-app-1.mit.edu.

which as of last week was pointing to kerberos-org.mit.edu. If the
change in DNS was intentional then the following patch resolves the issue:

src/tests/t_sn2princ.py:

@@ -69,7 +69,7 @@

# and reverse resolving to these names.

oname = 'ptr-mismatch.kerberos.org'

fname = 'www.kerberos.org'

-rname = 'kerberos-org.mit.edu'

+rname = 'kerborg-app-1.mit.edu'



# Verify forward resolution before testing for it.

try:


else please ignore this bug.

Shawn.
--
# Sat May 28 20:43:32 2016 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'open'
# Sat May 28 20:43:32 2016 ghudson@mit.edu (Greg Hudson) - Correspondence added
Download (untitled) / with headers
text/plain 394B
What version is this? As far as I can tell, t_sn2princ.py has always
checked the reverse resolution results before running the test, so it
should skip the test rather than failing.

(The PTR change is intentional. https://github.com/krb5/krb5/pull/457
revises the test to be less specific about the reverse resolution result,
but it should not be required for the test script to succeed.)
# Mon May 30 01:29:31 2016 Shawn Emery <shawn.emery@oracle.com> - Comments added
Date: Sun, 29 May 2016 23:29:25 -0600
From: Shawn M Emery <shawn.emery@oracle.com>
To: rt-comment@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #8424] New failure in t_sn2princ.py
RT-Send-Cc:
Download (untitled) / with headers
text/plain 893B


On 05/28/16 06:43 PM, Greg Hudson via RT wrote:
Show quoted text
> What version is this? As far as I can tell, t_sn2princ.py has always
> checked the reverse resolution results before running the test, so it
> should skip the test rather than failing.
>
> (The PTR change is intentional. https://github.com/krb5/krb5/pull/457
> revises the test to be less specific about the reverse resolution result,
> but it should not be required for the test script to succeed.)

Regarding not skipping the test case: yes, this module is patched in our
distribution and was not skipping the reverse lookup test in this
instance. However we would still like to have test coverage for reverse
resolution.

In regards to test case failure: yes, the above pull request does
resolve test failure. I've must of searched for issues in this test
module hours before the pull request was submitted.

Thanks,

Shawn.
--
# Mon May 30 14:14:15 2016 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'resolved'
# Mon May 30 14:14:15 2016 ghudson@mit.edu (Greg Hudson) - Correspondence added
Download (untitled) / with headers
text/plain 228B
Thanks. Tom's pull request to change t_sn2princ.py won't show up in RT
until it is merged, which is presumably why it wasn't found in your search.
I will close this ticket and add a link to #8422 once Tom merges his
commit.
# Mon May 30 14:14:24 2016 ghudson@mit.edu (Greg Hudson) - Tags nochange added
# Mon May 30 22:52:32 2016 ghudson@mit.edu (Greg Hudson) - Ticket 8424 RefersTo ticket 8422.