Skip Menu |
 

Subject: test_check_allowed_to_delegate() should free unparsed princ output
In test_check_allowed_to_delegate() there is:

check(krb5_unparse_name_flags(context, server->princ,
KRB5_PRINCIPAL_UNPARSE_NO_REALM,
&sprinc));
check(krb5_unparse_name_flags(context, proxy,
KRB5_PRINCIPAL_UNPARSE_NO_REALM,
&tprinc));

but because this function does not free sprinc/tprinc after those calls
memory leak checking reports leaks that are not important but this does
introduce unnecessary false positives when looking for real memory leaks
in krb5kdc.
From: ghudson@mit.edu
Subject: git commit

Fix leak in test_check_allowed_to_delegate()

sprinc and tprinc must be freed. Reported by Will Fiveash.

https://github.com/krb5/krb5/commit/a9478009dc9a5f554fbd7566432be8175e96ed50
Author: Greg Hudson <ghudson@mit.edu>
Commit: a9478009dc9a5f554fbd7566432be8175e96ed50
Branch: master
src/plugins/kdb/test/kdb_test.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
From: ghudson@mit.edu
Subject: git commit

Fix test_check_allowed_to_delegate() leak for real

Remove the conditional return from so that sprinc and tprinc are
always freed. Reported by Will Fiveash.

https://github.com/krb5/krb5/commit/b5a9fbe928ffc311a3abda562ef909cd7555b282
Author: Greg Hudson <ghudson@mit.edu>
Commit: b5a9fbe928ffc311a3abda562ef909cd7555b282
Branch: master
src/plugins/kdb/test/kdb_test.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)