Skip Menu |
 

History Show all quoted text — Show full headers
# Tue Aug 16 21:46:13 2016 tlyu (Taylor Yu) - Ticket created
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 602B

Improve EINTR handling in bttest

The libdb2 btree debugging program bttest doesn't handle EINTR in its
input loop. This causes difficulties with debugging using lldb,
because bttest gets signals like SIGSTOP when being attached, and lldb
doesn't seem to share the terminal well with a program being debugged.

https://github.com/krb5/krb5/commit/dbf6e70d04c094b6cf0ef076a62ef4ca27001183
Author: Tom Yu <tlyu@mit.edu>
Commit: dbf6e70d04c094b6cf0ef076a62ef4ca27001183
Branch: master
src/plugins/kdb/db2/libdb2/test/btree.tests/main.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
# Tue Aug 16 21:46:13 2016 tlyu (Taylor Yu) - Status changed from 'new' to 'review'
# Tue Aug 16 21:46:13 2016 tlyu (Taylor Yu) - Requestor tlyu (Taylor Yu) added
# Tue Aug 16 21:46:14 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 587B

Fix bttest printing of unterminated strings

The libdb2 btree debugging program bttest can attempt to print keys or
data that aren't null-terminated, reading past the end of the
length-counted byte array. Use the "%.*s" format specifier to provide
an explicit length when printing keys or data.

https://github.com/krb5/krb5/commit/503b912fa11db372db043a8b8fbce51e75b36eed
Author: Tom Yu <tlyu@mit.edu>
Commit: 503b912fa11db372db043a8b8fbce51e75b36eed
Branch: master
src/plugins/kdb/db2/libdb2/test/btree.tests/main.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
# Tue Aug 16 21:46:15 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 942B

Make bttest build with restricted lib exports

On platforms that use strict library export lists, the libdb2 btree
debugging program bttest won't build with -DDEBUG or -DSTATISTICS
because some needed functions aren't in the export list.

Add the missing bt_debug.c and mpool.c functions to libdb.exports.
Stub out these functions when built without -DDEBUG or -DSTATISTICS to
avoid unreferenced symbols, because conditionalizing library export
lists isn't easy.

https://github.com/krb5/krb5/commit/8c59d4cc3cfec84d6e4a694f87c319d2564984a3
Author: Tom Yu <tlyu@mit.edu>
Commit: 8c59d4cc3cfec84d6e4a694f87c319d2564984a3
Branch: master
src/plugins/kdb/db2/libdb2/btree/bt_debug.c | 27 +++++++++++++++++++++++++++
src/plugins/kdb/db2/libdb2/libdb.exports | 6 ++++++
src/plugins/kdb/db2/libdb2/mpool/mpool.c | 6 ++++++
src/plugins/kdb/db2/libdb2/mpool/mpool.h | 4 ++--
4 files changed, 41 insertions(+), 2 deletions(-)
# Tue Aug 16 21:46:15 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 308B

Fix void return in __bt_dpage

https://github.com/krb5/krb5/commit/84992bd7a9e1fd2f6b332d054aef9c8dfea84742
Author: Tom Yu <tlyu@mit.edu>
Commit: 84992bd7a9e1fd2f6b332d054aef9c8dfea84742
Branch: master
src/plugins/kdb/db2/libdb2/btree/bt_debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
# Tue Aug 16 21:46:16 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 1KiB

Fix MPOOL_IGNOREPIN to ease btree debugging

Various libdb2 test programs use the MPOOL_IGNOREPIN flag to examine
arbitrary mpool pages that may or may not be pinned. This flag is
apparently intended to allow fetching pages that are already pinned,
and to avoid setting the MPOOL_PINNED flag. When there was a cache
hit, mpool_get was setting MPOOL_PINNED anyway, causing aborts when
using debugging programs such as dbtest and bttest.

Fix this inconsistency by not setting MPOOL_PINNED when returning a
cached page when the caller requested MPOOL_IGNOREPIN. In bttest, add
MPOOL_IGNOREPIN to allow dumping of pages while they are pinned
without disrupting their pinned status.

https://github.com/krb5/krb5/commit/e6b4a19a546e0a171a416261cb06dfcc8e607e7b
Author: Tom Yu <tlyu@mit.edu>
Commit: e6b4a19a546e0a171a416261cb06dfcc8e607e7b
Branch: master
src/plugins/kdb/db2/libdb2/mpool/mpool.c | 3 ++-
src/plugins/kdb/db2/libdb2/test/btree.tests/main.c | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
# Thu Sep 08 15:26:44 2016 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 479B

Fix bt_debug.c unaligned accesses and formats

Use memcpy to fix some unaligned accesses in bt_debug.c. Also fix
some argument width issues with fprintf. Clean up warnings.

https://github.com/krb5/krb5/commit/1e4acf229a18b1c70c7664cf0af8ee0100fb2e26
Author: Tom Yu <tlyu@mit.edu>
Commit: 1e4acf229a18b1c70c7664cf0af8ee0100fb2e26
Branch: master
src/plugins/kdb/db2/libdb2/btree/bt_debug.c | 67 +++++++++++++++-----------
1 files changed, 39 insertions(+), 28 deletions(-)
# Thu Oct 13 16:45:43 2016 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Thu Oct 13 16:45:43 2016 tlyu (Taylor Yu) - Version_Fixed 1.15 added