Ticket History #8498: Potential memory leak in prepare_error

# Wed Sep 21 14:21:37 2016 wfiveash (Will Fiveash) - Ticket created

Subject:

Potential memory leak in prepare_error_as()

Download (untitled) / with headers
text/plain 253B

In https://github.com/krb5/krb5/blob/master/src/kdc/do_as_req.c at line
848 there is:

e_data = calloc(count + 2, sizeof(*e_data));

and later starting at line 861:

if (retval)
return retval;

Looks like e_data can be leaked at that return.

# Fri Sep 23 13:03:26 2016 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Fri Sep 23 13:03:26 2016 ghudson@mit.edu (Greg Hudson) - Target_Version 1.14-next added

# Fri Sep 23 13:03:26 2016 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'

# Fri Sep 23 13:03:26 2016 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Fri Sep 23 13:03:26 2016 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 487B

Fix unlikely leak in KDC AS-REQ error path

In prepare_error_as(), if krb5_us_timeofday() fails and error pa-data
was supplied, the FAST cookie and a shallow copy of the error padata
can be leaked. Reported by Will Fiveash.

https://github.com/krb5/krb5/commit/8d852c577039d59e1bea383e4ddfe575c20f240d
Author: Greg Hudson <ghudson@mit.edu>
Commit: 8d852c577039d59e1bea383e4ddfe575c20f240d
Branch: master
src/kdc/do_as_req.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

# Mon Oct 24 15:57:48 2016 tlyu (Taylor Yu) - Version_Fixed 1.14.5 added

# Mon Oct 24 15:57:48 2016 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 593B

Fix unlikely leak in KDC AS-REQ error path

In prepare_error_as(), if krb5_us_timeofday() fails and error pa-data
was supplied, the FAST cookie and a shallow copy of the error padata
can be leaked. Reported by Will Fiveash.

(cherry picked from commit 8d852c577039d59e1bea383e4ddfe575c20f240d)

https://github.com/krb5/krb5/commit/b5cd94af456bd62a0f71c5bf88dd6a74b5671653
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: b5cd94af456bd62a0f71c5bf88dd6a74b5671653
Branch: krb5-1.14
src/kdc/do_as_req.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

# Mon Oct 24 17:07:47 2016 tlyu (Taylor Yu) - CustomField pullup deleted

# Mon Oct 24 17:12:39 2016 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Mon Nov 14 16:55:03 2016 tlyu (Taylor Yu) - Version_Fixed 1.15 added

Ticket History #8498: Potential memory leak in prepare_error_as()