Ticket History #8533: Bug in src/tests/responder.c

# Fri Jan 06 11:31:00 2017 Dorian Ducournau <dodo040@hotmail.fr> - Ticket created

From:	Dorian Ducournau <dodo040@hotmail.fr>
To:	"krb5-bugs@mit.edu" <krb5-bugs@mit.edu>
Subject:	Bug in src/tests/responder.c
Date:	Fri, 6 Jan 2017 16:17:58 +0000

Download (untitled) / with headers
text/plain 237B

Download (untitled) / with headers
text/html 1.3KiB

Hello,

I found a bug line 229 of responder.c :

Instead of :

if (strncmp(chl->identities[0]->identity, "PKCS12:", 5) == 0)

should be :

if (strncmp(chl->identities[0]->identity, "PKCS12:", 7) == 0)

Regards

Dorian Ducournau

# Fri Jan 06 11:47:27 2017 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'open'

# Fri Jan 06 11:47:27 2017 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 138B

Thanks, we'll fix that. Out of curiosity, did you find this with an
automated tool, or did you just happen to be looking over that file?

# Fri Jan 06 12:28:44 2017 Dorian Ducournau <dodo040@hotmail.fr> - Comments added

From:	Dorian Ducournau <dodo040@hotmail.fr>
To:	"rt-comment@krbdev.mit.edu" <rt-comment@krbdev.mit.edu>
Subject:	RE: [krbdev.mit.edu #8533] Bug in src/tests/responder.c
Date:	Fri, 6 Jan 2017 17:28:39 +0000
RT-Send-Cc:

Download (untitled) / with headers
text/plain 674B

Download (untitled) / with headers
text/html 1.4KiB

I'm implementing a program using a responder callback. I was using the responder test to see how it works. And succeeded at the end in the test. Not yet in the program because I get 'no questions to ask' in pkinit_client_prep_questions. I'm currently working on it. Besides if you have any clue on this point I take it.

De : Greg Hudson via RT <rt-comment@krbdev.mit.edu>
EnvoyÃ© : vendredi 6 janvier 2017 17:47
Ã� : dodo040@hotmail.fr
Objet : [krbdev.mit.edu #8533] Bug in src/tests/responder.c

Thanks, we'll fix that. Out of curiosity, did you find this with an
automated tool, or did you just happen to be looking over that file?

# Fri Jan 06 13:52:58 2017 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Fri Jan 06 13:52:58 2017 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'review'

# Fri Jan 06 13:52:58 2017 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 380B

Fix minor bug in responder.c test program

"PKCS12:" has seven characters, not five. Reported by Dorian Ducournau.

https://github.com/krb5/krb5/commit/2e51416b998ff7a0c6cf361de7b8bb241b4262fd
Author: Greg Hudson <ghudson@mit.edu>
Commit: 2e51416b998ff7a0c6cf361de7b8bb241b4262fd
Branch: master
src/tests/responder.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

# Sun Sep 24 20:40:01 2017 ghudson@mit.edu (Greg Hudson) - Status changed from 'review' to 'resolved'

# Wed Oct 04 10:52:57 2017 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.16 added