Skip Menu |
 

From: John Hascall <john@iastate.edu>
Date: Tue, 22 Aug 2017 12:04:44 -0500
Subject: kpropd should write a pidfile when started in standalone mode...
To: krb5-bugs@mit.edu

Message body is not shown because sender requested not to inline it.

...so it can be properly managed by systemctl etc.

I have included a sample patch to implement this.

# ./kpropd -h
Usage: ./kpropd [-r realm] [-s srvtab] [-dS] [-f slave_file]
 [-F kerberos_db_file ] [-u kdb5_util_pathname]
 [-x db_args]* [-p port] [-a acl_file]
 [-P pid_file] (standalone mode only)
 [-A admin_server]

John
Date: Tue, 22 Aug 2017 17:00:41 -0500
From: Will Fiveash <will.fiveash@oracle.com>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #8607] kpropd should write a pidfile when started in standalone mode...
RT-Send-Cc:
On Tue, Aug 22, 2017 at 01:47:40PM -0400, john@iastate.edu via RT wrote:
Show quoted text
> ...so it can be properly managed by systemctl etc.
>
> I have included a sample patch to implement this.
> NOTE: I changed the command line flags to match the other kerberos daemons
> <https://imgflip.com/i/1uj6yv>:
>
> # ./kpropd -h
> Usage: ./kpropd [-r realm] [-s srvtab] [-dS] [-f slave_file]
> [-F kerberos_db_file ] [-u kdb5_util_pathname]
> [-x db_args]* [-p port] [-a acl_file]
> [-P pid_file] (standalone mode only)
> [-A admin_server]

Interface stability is an issue I have with this patch. I would prefer
a unique flag other than -P be used to provide the pid file name.

--
Will Fiveash
Oracle Solaris Software Engineer
Subject: Re: [krbdev.mit.edu #8607] kpropd should write a pidfile when started in standalone mode...
From: John Hascall <hascall@gmail.com>
Date: Tue, 22 Aug 2017 17:56:29 -0500
CC: john@iastate.edu
To: rt-comment@krbdev.mit.edu
RT-Send-Cc:
I figured that ;)
It's just too bad nobody thought about flags consistency earlier...


John Hascall
IT Services
Iowa State Univ.

Show quoted text
> On Aug 22, 2017, at 5:03 PM, will.fiveash@oracle.com via RT <rt-comment@krbdev.mit.edu> wrote:
>
>> On Tue, Aug 22, 2017 at 01:47:40PM -0400, john@iastate.edu via RT wrote:
>> ...so it can be properly managed by systemctl etc.
>>
>> I have included a sample patch to implement this.
>> NOTE: I changed the command line flags to match the other kerberos daemons
>> <https://imgflip.com/i/1uj6yv>:
>>
>> # ./kpropd -h
>> Usage: ./kpropd [-r realm] [-s srvtab] [-dS] [-f slave_file]
>> [-F kerberos_db_file ] [-u kdb5_util_pathname]
>> [-x db_args]* [-p port] [-a acl_file]
>> [-P pid_file] (standalone mode only)
>> [-A admin_server]
>
> Interface stability is an issue I have with this patch. I would prefer
> a unique flag other than -P be used to provide the pid file name.
>
> --
> Will Fiveash
> Oracle Solaris Software Engineer
>
From: ghudson@mit.edu
Subject: git commit

Add --pid-file option to kpropd

https://github.com/krb5/krb5/commit/99f631ac5f7dfb6a9a9c77b2ce46c8fb3e8943cf
Author: Greg Hudson <ghudson@mit.edu>
Commit: 99f631ac5f7dfb6a9a9c77b2ce46c8fb3e8943cf
Branch: master
doc/admin/admin_commands/kpropd.rst | 5 ++++
src/slave/kpropd.c | 36 +++++++++++++++++++++++++++++++++-
2 files changed, 39 insertions(+), 2 deletions(-)