Ticket History #8640: krb5 build

# Tue Feb 06 10:45:56 2018 Rostyk <rostyk87@gmail.com> - Ticket created

From:	Rostyk <rostyk87@gmail.com>
Date:	Tue, 6 Feb 2018 16:36:18 +0200
Subject:	krb5 build
To:	krb5-bugs@mit.edu

Download 2018-02-06_15-43-15-000106.jpg
image/jpeg 716.6KiB

Image not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 537B

Download (untitled) / with headers
text/html 950B

Hello Everyone,

Could you please help me to build a krb5 client for Windows.

I've installed all required software from this instruction:

https://github.com/krb5/krb5/tree/master/src/windows

and I've successfully created a krb5 installation package for x86 CPU but when I try to run command "nmake" with "CPU=AMD64" i received error:

"NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\Bin\amd64\cl.EXE"' : return code '0x2'"

I'm using:

branch: krb5-1.16

OS: Windows 7 x64

--

Best Regards,
Rostyk

# Tue Feb 06 11:17:40 2018 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'open'

# Tue Feb 06 11:17:40 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 481B

Hi. It looks like we introduced a small bug into Leash last April
which caused this build failure. (We only create a new Windows release
every few years, and our continuous integration for Windows doesn't
currently include the Leash build.)

You should be able to rectify this bug by editing
src/windows/leash/LeashView.h, searching for AddDisplayItem, and
changing the three "long" parameters (issued, valid_until, and
renew_until) to "time_t". Let me know if that works.

# Tue Feb 06 11:43:26 2018 Rostyk <rostyk87@gmail.com> - Comments added

From:	Rostyk <rostyk87@gmail.com>
Date:	Tue, 6 Feb 2018 18:43:19 +0200
Subject:	Re: [krbdev.mit.edu #8640] krb5 build
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download 2018-02-06_18-35-19-000108.jpg
image/jpeg 43.3KiB

Image not shown because sender requested not to inline it.

Download 2018-02-06_18-33-21-000107.jpg
image/jpeg 773.2KiB

Image not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 787B

Download (untitled) / with headers
text/html 1.3KiB

Hi Greg,

Many thanks for the reply so fast.

I've made changes as you recommended and compilation failed with other error.

Please take a look at attached screenshots.

Regards,

Rostyk

2018-02-06 18:17 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:

Show quoted text

Hi. It looks like we introduced a small bug into Leash last April
which caused this build failure. (We only create a new Windows release
every few years, and our continuous integration for Windows doesn't
currently include the Leash build.)

You should be able to rectify this bug by editing
src/windows/leash/LeashView.h, searching for AddDisplayItem, and
changing the three "long" parameters (issued, valid_until, and
renew_until) to "time_t". Let me know if that works.

--

Best Regards,
Rostyk

# Tue Feb 06 11:43:26 2018 Rostyk <rostyk87@gmail.com> - Correspondence added

From:	Rostyk <rostyk87@gmail.com>
Date:	Tue, 6 Feb 2018 18:43:19 +0200
Subject:	Re: [krbdev.mit.edu #8640] krb5 build
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download 2018-02-06_18-35-19-000108.jpg
image/jpeg 43.3KiB

Image not shown because sender requested not to inline it.

Download 2018-02-06_18-33-21-000107.jpg
image/jpeg 773.2KiB

Image not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 787B

Download (untitled) / with headers
text/html 1.3KiB

Hi Greg,

Many thanks for the reply so fast.

I've made changes as you recommended and compilation failed with other error.

Please take a look at attached screenshots.

Regards,

Rostyk

2018-02-06 18:17 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:

Show quoted text

Hi. It looks like we introduced a small bug into Leash last April
which caused this build failure. (We only create a new Windows release
every few years, and our continuous integration for Windows doesn't
currently include the Leash build.)

You should be able to rectify this bug by editing
src/windows/leash/LeashView.h, searching for AddDisplayItem, and
changing the three "long" parameters (issued, valid_until, and
renew_until) to "time_t". Let me know if that works.

--

Best Regards,
Rostyk

# Tue Feb 06 11:56:20 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 131B

Sorry, I was suggesting that you change "long" to "time_t" for those
three parameters, not change the parameter names to "time_t".

# Wed Feb 07 03:40:18 2018 Rostyk <rostyk87@gmail.com> - Comments added

From:	Rostyk <rostyk87@gmail.com>
Date:	Wed, 7 Feb 2018 10:40:15 +0200
Subject:	Re: [krbdev.mit.edu #8640] krb5 build
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 439B

Download (untitled) / with headers
text/html 1015B

Hi,

I'm sorry it's my mistake.

I've made the changes and successfully compiled the build.
Can I clone this branch into my git repository with your fix?

Thanks alot for your help

Regards,

Rostyk

2018-02-06 18:56 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:

Show quoted text

Sorry, I was suggesting that you change "long" to "time_t" for those
three parameters, not change the parameter names to "time_t".

--

Best Regards,
Rostyk

# Wed Feb 07 03:40:18 2018 Rostyk <rostyk87@gmail.com> - Correspondence added

From:	Rostyk <rostyk87@gmail.com>
Date:	Wed, 7 Feb 2018 10:40:15 +0200
Subject:	Re: [krbdev.mit.edu #8640] krb5 build
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 439B

Download (untitled) / with headers
text/html 1015B

Hi,

I'm sorry it's my mistake.

I've made the changes and successfully compiled the build.
Can I clone this branch into my git repository with your fix?

Thanks alot for your help

Regards,

Rostyk

2018-02-06 18:56 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:

Show quoted text

Sorry, I was suggesting that you change "long" to "time_t" for those
three parameters, not change the parameter names to "time_t".

--

Best Regards,
Rostyk

# Wed Feb 07 10:40:33 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 86B

Sure. I will also apply the fix to our repository soon, now that you
have tested it.

# Wed Feb 07 19:49:19 2018 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'resolved'

# Wed Feb 07 19:49:19 2018 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Wed Feb 07 19:49:19 2018 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Wed Feb 07 19:49:19 2018 ghudson@mit.edu (Greg Hudson) - Target_Version 1.16-next added

# Wed Feb 07 19:49:19 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 510B

Fix Leash AddDisplayItem() declaration

Commit a9cbbf0899f270fbb14f63ffbed1b6d542333641 changed three
parameters in AddDisplayItem() from long to time_t, but did not change
the corresponding declaration in LeashView.h. Fix that now.

https://github.com/krb5/krb5/commit/b1367abb2e2ff14446371155cb7e23a29b76aa87
Author: Greg Hudson <ghudson@mit.edu>
Commit: b1367abb2e2ff14446371155cb7e23a29b76aa87
Branch: master
src/windows/leash/LeashView.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

# Thu Feb 08 06:39:41 2018 Rostyk <rostyk87@gmail.com> - Comments added

From:	Rostyk <rostyk87@gmail.com>
Date:	Thu, 8 Feb 2018 13:39:37 +0200
Subject:	Re: [krbdev.mit.edu #8640] krb5 build
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 706B

Download (untitled) / with headers
text/html 1.2KiB

Ho Greg,

I'm sorry for bothering you once again but maybe you can help me.

After your changes, I've successfully compiled MSI package and now I'm testing it on one of my instances and I received next error:

command: & $kinit -kt "path\user.keytab" user@CLUSTER.LOCAL

kinit.exe: Cannot determine realm for host (principal host/tab-vpc-mig-src

Funny things what on the same instance but with old MIT kerberos client 4.1 works perfectly.

I've tried to find some solution but nothing helps.

Regards,

Rostyk

2018-02-07 17:40 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:

Show quoted text

Sure. I will also apply the fix to our repository soon, now that you
have tested it.

--

Best Regards,
Rostyk

# Thu Feb 08 06:39:41 2018 Rostyk <rostyk87@gmail.com> - Correspondence added

From:	Rostyk <rostyk87@gmail.com>
Date:	Thu, 8 Feb 2018 13:39:37 +0200
Subject:	Re: [krbdev.mit.edu #8640] krb5 build
To:	rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Download (untitled) / with headers
text/plain 706B

Download (untitled) / with headers
text/html 1.2KiB

Ho Greg,

I'm sorry for bothering you once again but maybe you can help me.

After your changes, I've successfully compiled MSI package and now I'm testing it on one of my instances and I received next error:

command: & $kinit -kt "path\user.keytab" user@CLUSTER.LOCAL

kinit.exe: Cannot determine realm for host (principal host/tab-vpc-mig-src

Funny things what on the same instance but with old MIT kerberos client 4.1 works perfectly.

I've tried to find some solution but nothing helps.

Regards,

Rostyk

2018-02-07 17:40 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:

Show quoted text

Sure. I will also apply the fix to our repository soon, now that you
have tested it.

--

Best Regards,
Rostyk

# Thu Feb 08 12:02:26 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 646B

That error message should only occur when you run kinit -k without
specifying a client principal name on the command line.

Since you clearly are specifying a principal name, my best guess is
that we introduced an argument parsing bug on Windows when we added
getopt_long() support to the Unix build (in commit
8f9ade8ec50cde1176411085294f85ecfb2820a4 on Feb 24 2016).
Specifically, I suspect the "optind" variable as seen by kinit is not
set correctly after the call to getopt_long().

Unfortunately, I don't currently have the ability to investigate
further without spending a lot of time spinning up a Windows
development environment.

# Wed May 02 01:25:32 2018 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.16.1 added

# Wed May 02 01:25:32 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 583B

Fix Leash AddDisplayItem() declaration

Commit a9cbbf0899f270fbb14f63ffbed1b6d542333641 changed three
parameters in AddDisplayItem() from long to time_t, but did not change
the corresponding declaration in LeashView.h. Fix that now.

(cherry picked from commit b1367abb2e2ff14446371155cb7e23a29b76aa87)

https://github.com/krb5/krb5/commit/20960dd4e3be0f95fa3f8aad168eb8b8aadbc86f
Author: Greg Hudson <ghudson@mit.edu>
Commit: 20960dd4e3be0f95fa3f8aad168eb8b8aadbc86f
Branch: krb5-1.16
src/windows/leash/LeashView.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

# Wed May 02 10:16:07 2018 ghudson@mit.edu (Greg Hudson) - CustomField pullup deleted

# Tue Jun 12 12:19:14 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 121B

The argument parsing bug is fixed in the master branch by commit
63246cf3513a0e8bdfc734db985af14c8c5170c5 (ticket 8684).

# Tue Jun 12 12:19:28 2018 ghudson@mit.edu (Greg Hudson) - Ticket 8640 RefersTo ticket 8684.