Skip Menu |
 

From: Rostyk <rostyk87@gmail.com>
Date: Tue, 6 Feb 2018 16:36:18 +0200
Subject: krb5 build
To: krb5-bugs@mit.edu

Image not shown because sender requested not to inline it.

Hello Everyone,

Could you please help me to build a krb5 client for Windows.

I've installed all required software from this instruction:
and I've successfully created a krb5 installation package for x86 CPU but when I try to run command "nmake" with "CPU=AMD64" i received error:
"NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\Bin\amd64\cl.EXE"' : return code '0x2'"

I'm using:
branch: krb5-1.16
OS: Windows 7 x64


--
Best Regards,
Rostyk
Hi. It looks like we introduced a small bug into Leash last April
which caused this build failure. (We only create a new Windows release
every few years, and our continuous integration for Windows doesn't
currently include the Leash build.)

You should be able to rectify this bug by editing
src/windows/leash/LeashView.h, searching for AddDisplayItem, and
changing the three "long" parameters (issued, valid_until, and
renew_until) to "time_t". Let me know if that works.
From: Rostyk <rostyk87@gmail.com>
Date: Tue, 6 Feb 2018 18:43:19 +0200
Subject: Re: [krbdev.mit.edu #8640] krb5 build
To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Image not shown because sender requested not to inline it.

Image not shown because sender requested not to inline it.

Hi Greg,

Many thanks for the reply so fast.
I've made changes as you recommended and compilation failed with other error.
Please take a look at attached screenshots.

Regards,
Rostyk


2018-02-06 18:17 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:
Show quoted text
Hi.  It looks like we introduced a small bug into Leash last April
which caused this build failure.  (We only create a new Windows release
every few years, and our continuous integration for Windows doesn't
currently include the Leash build.)

You should be able to rectify this bug by editing
src/windows/leash/LeashView.h, searching for AddDisplayItem, and
changing the three "long" parameters (issued, valid_until, and
renew_until) to "time_t".  Let me know if that works.



--
Best Regards,
Rostyk
From: Rostyk <rostyk87@gmail.com>
Date: Tue, 6 Feb 2018 18:43:19 +0200
Subject: Re: [krbdev.mit.edu #8640] krb5 build
To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:

Image not shown because sender requested not to inline it.

Image not shown because sender requested not to inline it.

Hi Greg,

Many thanks for the reply so fast.
I've made changes as you recommended and compilation failed with other error.
Please take a look at attached screenshots.

Regards,
Rostyk


2018-02-06 18:17 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:
Show quoted text
Hi.  It looks like we introduced a small bug into Leash last April
which caused this build failure.  (We only create a new Windows release
every few years, and our continuous integration for Windows doesn't
currently include the Leash build.)

You should be able to rectify this bug by editing
src/windows/leash/LeashView.h, searching for AddDisplayItem, and
changing the three "long" parameters (issued, valid_until, and
renew_until) to "time_t".  Let me know if that works.



--
Best Regards,
Rostyk
Sorry, I was suggesting that you change "long" to "time_t" for those
three parameters, not change the parameter names to "time_t".
From: Rostyk <rostyk87@gmail.com>
Date: Wed, 7 Feb 2018 10:40:15 +0200
Subject: Re: [krbdev.mit.edu #8640] krb5 build
To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:
Hi,
I'm sorry it's my mistake.
I've made the changes and successfully compiled the build.
Can I clone this branch into my git repository with your fix?
Thanks alot for your help

Regards,
Rostyk

2018-02-06 18:56 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:
Show quoted text
Sorry, I was suggesting that you change "long" to "time_t" for those
three parameters, not change the parameter names to "time_t".



--
Best Regards,
Rostyk
From: Rostyk <rostyk87@gmail.com>
Date: Wed, 7 Feb 2018 10:40:15 +0200
Subject: Re: [krbdev.mit.edu #8640] krb5 build
To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:
Hi,
I'm sorry it's my mistake.
I've made the changes and successfully compiled the build.
Can I clone this branch into my git repository with your fix?
Thanks alot for your help

Regards,
Rostyk

2018-02-06 18:56 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:
Show quoted text
Sorry, I was suggesting that you change "long" to "time_t" for those
three parameters, not change the parameter names to "time_t".



--
Best Regards,
Rostyk
Sure. I will also apply the fix to our repository soon, now that you
have tested it.
From: ghudson@mit.edu
Subject: git commit

Fix Leash AddDisplayItem() declaration

Commit a9cbbf0899f270fbb14f63ffbed1b6d542333641 changed three
parameters in AddDisplayItem() from long to time_t, but did not change
the corresponding declaration in LeashView.h. Fix that now.

https://github.com/krb5/krb5/commit/b1367abb2e2ff14446371155cb7e23a29b76aa87
Author: Greg Hudson <ghudson@mit.edu>
Commit: b1367abb2e2ff14446371155cb7e23a29b76aa87
Branch: master
src/windows/leash/LeashView.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
From: Rostyk <rostyk87@gmail.com>
Date: Thu, 8 Feb 2018 13:39:37 +0200
Subject: Re: [krbdev.mit.edu #8640] krb5 build
To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:
Ho Greg,

I'm sorry for bothering you once again but maybe you can help me.
After your changes, I've successfully compiled MSI package and now I'm testing it on one of my instances and I received next error:
command: & $kinit -kt "path\user.keytab" user@CLUSTER.LOCAL
kinit.exe: Cannot determine realm for host (principal host/tab-vpc-mig-src
Funny things what on the same instance but with old MIT kerberos client 4.1 works perfectly.
I've tried to find some solution but nothing helps.

Regards,
Rostyk

2018-02-07 17:40 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:
Show quoted text
Sure.  I will also apply the fix to our repository soon, now that you
have tested it.



--
Best Regards,
Rostyk
From: Rostyk <rostyk87@gmail.com>
Date: Thu, 8 Feb 2018 13:39:37 +0200
Subject: Re: [krbdev.mit.edu #8640] krb5 build
To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu
RT-Send-Cc:
Ho Greg,

I'm sorry for bothering you once again but maybe you can help me.
After your changes, I've successfully compiled MSI package and now I'm testing it on one of my instances and I received next error:
command: & $kinit -kt "path\user.keytab" user@CLUSTER.LOCAL
kinit.exe: Cannot determine realm for host (principal host/tab-vpc-mig-src
Funny things what on the same instance but with old MIT kerberos client 4.1 works perfectly.
I've tried to find some solution but nothing helps.

Regards,
Rostyk

2018-02-07 17:40 GMT+02:00 Greg Hudson via RT <rt-comment@krbdev.mit.edu>:
Show quoted text
Sure.  I will also apply the fix to our repository soon, now that you
have tested it.



--
Best Regards,
Rostyk
That error message should only occur when you run kinit -k without
specifying a client principal name on the command line.

Since you clearly are specifying a principal name, my best guess is
that we introduced an argument parsing bug on Windows when we added
getopt_long() support to the Unix build (in commit
8f9ade8ec50cde1176411085294f85ecfb2820a4 on Feb 24 2016).
Specifically, I suspect the "optind" variable as seen by kinit is not
set correctly after the call to getopt_long().

Unfortunately, I don't currently have the ability to investigate
further without spending a lot of time spinning up a Windows
development environment.
From: ghudson@mit.edu
Subject: git commit

Fix Leash AddDisplayItem() declaration

Commit a9cbbf0899f270fbb14f63ffbed1b6d542333641 changed three
parameters in AddDisplayItem() from long to time_t, but did not change
the corresponding declaration in LeashView.h. Fix that now.

(cherry picked from commit b1367abb2e2ff14446371155cb7e23a29b76aa87)

https://github.com/krb5/krb5/commit/20960dd4e3be0f95fa3f8aad168eb8b8aadbc86f
Author: Greg Hudson <ghudson@mit.edu>
Commit: 20960dd4e3be0f95fa3f8aad168eb8b8aadbc86f
Branch: krb5-1.16
src/windows/leash/LeashView.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
The argument parsing bug is fixed in the master branch by commit
63246cf3513a0e8bdfc734db985af14c8c5170c5 (ticket 8684).