Skip Menu |
 

History Show all quoted text — Show full headers
# Thu Oct 25 12:00:25 2018 Bean Zhang <bean.zhang@wesoft.com> - Ticket created
From: Bean Zhang <bean.zhang@wesoft.com>
To: "krb5-bugs@mit.edu" <krb5-bugs@mit.edu>
Subject: Resource leak in kadm5_randkey_principal_3()
Date: Thu, 11 Oct 2018 12:50:10 +0000
Download (untitled) / with headers
text/plain 326B
Download (untitled) / with headers
text/html 3.3KiB

Hi Team,

 

In kadm5_randkey_principal_3() of krb5-1.16.1/src/lib/kadm5/srv/svr_principal.c,

when call apply_keysalt_policy(), it will allocate memory for pointer new_ks_tuple,

but later if keepold is not zero, it just return KADM5_PROTECT_PRINCIPAL without free new_ks_tuple.

 

Could someone help to take a look?

 

Thanks,

Bean

 

# Fri Oct 26 10:42:08 2018 ghudson@mit.edu (Greg Hudson) - Target_Version 1.16-next added
# Fri Oct 26 10:42:08 2018 ghudson@mit.edu (Greg Hudson) - Target_Version 1.15-next added
# Fri Oct 26 10:42:08 2018 ghudson@mit.edu (Greg Hudson) - Tags pullup added
# Fri Oct 26 10:42:08 2018 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'resolved'
# Fri Oct 26 10:42:08 2018 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Fri Oct 26 10:42:08 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 540B

Fix leak on error in kadm5 randkey handling

An attempt to change the kadmin/history key with the -keepold flag
would leak the KDB entry and keysalt tuple as it returned an error.
Use the cleanup handler instead of returning directly. Reported by
Bean Zhang.

https://github.com/krb5/krb5/commit/c4bdb3a1c890149a472ed98a94cf85316b143265
Author: Greg Hudson <ghudson@mit.edu>
Commit: c4bdb3a1c890149a472ed98a94cf85316b143265
Branch: master
src/lib/kadm5/srv/svr_principal.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
# Sat Oct 27 11:45:52 2018 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.17 added
# Tue Oct 30 12:26:08 2018 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.16.2 added
# Tue Oct 30 12:26:08 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 613B

Fix leak on error in kadm5 randkey handling

An attempt to change the kadmin/history key with the -keepold flag
would leak the KDB entry and keysalt tuple as it returned an error.
Use the cleanup handler instead of returning directly. Reported by
Bean Zhang.

(cherry picked from commit c4bdb3a1c890149a472ed98a94cf85316b143265)

https://github.com/krb5/krb5/commit/60766c9854e8a03afdd22258b38832a13fb584ff
Author: Greg Hudson <ghudson@mit.edu>
Commit: 60766c9854e8a03afdd22258b38832a13fb584ff
Branch: krb5-1.16
src/lib/kadm5/srv/svr_principal.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
# Tue Oct 30 12:27:50 2018 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.15.4 added
# Tue Oct 30 12:27:50 2018 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 613B

Fix leak on error in kadm5 randkey handling

An attempt to change the kadmin/history key with the -keepold flag
would leak the KDB entry and keysalt tuple as it returned an error.
Use the cleanup handler instead of returning directly. Reported by
Bean Zhang.

(cherry picked from commit c4bdb3a1c890149a472ed98a94cf85316b143265)

https://github.com/krb5/krb5/commit/8ce051e31b7e47fc22421576f87549c1ca318302
Author: Greg Hudson <ghudson@mit.edu>
Commit: 8ce051e31b7e47fc22421576f87549c1ca318302
Branch: krb5-1.15
src/lib/kadm5/srv/svr_principal.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
# Tue Oct 30 12:29:00 2018 ghudson@mit.edu (Greg Hudson) - CustomField pullup deleted