Skip Menu |
 

History Show all quoted text — Show full headers
# Tue Jun 11 11:16:30 2019 ghudson@mit.edu (Greg Hudson) - Ticket created
Subject: kproplog cannot display LOCKDOWN_KEYS attribute
Download (untitled) / with headers
text/plain 632B
Ticket 8125 (commit 971fae8285427b27dfd8c9a535a18eb588ee0689) added
krb5_flags_to_strings() and used it in kadmin.c, replacing the local
flags table there. It left alone the local flags table and
print_flags() function in kproplog.c.

Ticket 8365 (commit 534db9834d6a77dc5e948e12844e72ba4e971e8c) added the
lockdown_keys flag, but did not update the table in kproplog.c.

kproplog only displays attribute flags in double-verbose mode (-vv), so
this omission is probably not noticeable, but for code hygiene the
local flags table in kproplog should be removed in favor of
krb5_flags_to_strings(), just as it was for kadmin.
# Tue Jun 11 11:19:21 2019 ghudson@mit.edu (Greg Hudson) - Ticket 8816 RefersTo ticket 8125.
# Tue Jun 11 11:19:21 2019 ghudson@mit.edu (Greg Hudson) - Ticket 8816 RefersTo ticket 8365.
# Tue Jun 11 11:20:28 2019 ghudson@mit.edu (Greg Hudson) - Ticket 8816 no longer RefersTo ticket fsck.com-rt://mit.edu/krbdev.mit.edu/ticket/8125.
# Tue Jun 11 11:20:28 2019 ghudson@mit.edu (Greg Hudson) - Ticket 8816 RefersTo ticket 8215.
# Wed Jun 12 18:59:29 2019 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Wed Jun 12 18:59:29 2019 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'resolved'
# Wed Jun 12 18:59:29 2019 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 537B

Use krb5_flags_to_strings() in kproplog

Remove the local flags table in kproplog.c and instead use
krb5_flags_to_strings(), as was done for kadmin.c in commit
971fae8285427b27dfd8c9a535a18eb588ee0689.

https://github.com/krb5/krb5/commit/5c52e281dd30ec7a6cdda2567c2db6dd56e97e93
Author: Greg Hudson <ghudson@mit.edu>
Commit: 5c52e281dd30ec7a6cdda2567c2db6dd56e97e93
Branch: master
src/kprop/deps | 2 +-
src/kprop/kproplog.c | 40 ++++++++++------------------------------
2 files changed, 11 insertions(+), 31 deletions(-)
# Tue Jan 07 20:03:18 2020 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.18 added