Skip Menu |
 

Download (untitled) / with headers
text/plain 3.8KiB
From donn@u.washington.edu Fri Sep 15 16:41:05 2000
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28])
by rt-11.mit.edu (8.9.3/8.9.3) with SMTP id QAA27107
for <bugs@RT-11.MIT.EDU>; Fri, 15 Sep 2000 16:41:04 -0400 (EDT)
Received: from melville.u.washington.edu by MIT.EDU with SMTP
id AA03650; Fri, 15 Sep 00 16:41:37 EDT
Received: (from donn@localhost)
by melville.u.washington.edu (8.9.3+UW00.05/8.9.3+UW99.09) id NAA66930;
Fri, 15 Sep 2000 13:41:03 -0700
Message-Id: <200009152041.NAA66930@melville.u.washington.edu>
Date: Fri, 15 Sep 2000 13:41:03 -0700
From: donn@u.washington.edu
Reply-To: donn@u.washington.edu
To: krb5-bugs@MIT.EDU
Cc:
Subject: ftpd logwtmp partially updates utmp struct
X-Send-Pr-Version: 3.99

Show quoted text
>Number: 888
>Category: krb5-appl
>Synopsis: ftpd logwtmp fails to update ut_type and ut_pid
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: krb5-unassigned
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Fri Sep 15 16:42:00 EDT 2000
>Last-Modified: Fri Sep 15 20:04:00 EDT 2000
>Originator: Donn Cave
>Organization:
University Computing Services
University of Washington
Show quoted text
>Release: krb5-1.2.1
>Environment:
Digital UNIX, AIX.

Show quoted text
>Description:
Failure to update ut_type and ut_pid fields puts garbage in
the file.
Show quoted text
>How-To-Repeat:
Use ftpd on Digital UNIX, look at history afterwards.
Show quoted text
>Fix:
The util/pty utmp code already has the autoconfig smarts to
deal with this issue, the following is a system-dependent
change that works on our hosts.

*** gssftp/ftpd/logwtmp.c.dist Thu Jun 29 19:27:07 2000
--- gssftp/ftpd/logwtmp.c Mon Jun 26 15:06:40 2000
***************
*** 79,84 ****
--- 79,86 ----
if (fstat(fd, &buf) == 0) {
(void)strncpy(ut.ut_line, line, sizeof(ut.ut_line));
(void)strncpy(ut.ut_name, name, sizeof(ut.ut_name));
+ ut.ut_type = DEAD_PROCESS;
+ ut.ut_pid = getpid();
#ifndef NO_UT_HOST
(void)strncpy(ut.ut_host, host, sizeof(ut.ut_host));
#endif
Show quoted text
>Audit-Trail:

From: Tom Yu <tlyu@MIT.EDU>
To: donn@u.washington.edu
Cc: krb5-bugs@MIT.EDU
Subject: Re: krb5-appl/888: ftpd logwtmp partially updates utmp struct
Date: 15 Sep 2000 19:50:05 -0400

Show quoted text
>>>>> "donn" == donn <donn@u.washington.edu> writes:

Show quoted text
donn> The util/pty utmp code already has the autoconfig smarts to
donn> deal with this issue, the following is a system-dependent
donn> change that works on our hosts.

Show quoted text
donn> *** gssftp/ftpd/logwtmp.c.dist Thu Jun 29 19:27:07 2000
donn> --- gssftp/ftpd/logwtmp.c Mon Jun 26 15:06:40 2000

Are you sure this actually has any effect? krb5-1.2.1 shouldn't be
using this file at all. pty_logwtmp() is being called instead. In
fact, I don't think gssftp/ftpd/logwtmp.c is getting compiled at all.

---Tom

From: Donn Cave <donn@u.washington.edu>
To: Tom Yu <tlyu@MIT.EDU>
Cc: <krb5-bugs@MIT.EDU>
Subject: Re: krb5-appl/888: ftpd logwtmp partially updates utmp struct
Date: Fri, 15 Sep 2000 17:03:46 -0700

Quoth Tom Yu <tlyu@MIT.EDU>:
| >>>>> "donn" == donn <donn@u.washington.edu> writes:
|
| donn> The util/pty utmp code already has the autoconfig smarts to
| donn> deal with this issue, the following is a system-dependent
| donn> change that works on our hosts.
|
| donn> *** gssftp/ftpd/logwtmp.c.dist Thu Jun 29 19:27:07 2000
| donn> --- gssftp/ftpd/logwtmp.c Mon Jun 26 15:06:40 2000
|
| Are you sure this actually has any effect? krb5-1.2.1 shouldn't be
| using this file at all. pty_logwtmp() is being called instead. In
| fact, I don't think gssftp/ftpd/logwtmp.c is getting compiled at all.

Now that you mention it, it looks to me like that is the case.
Sorry, I was confused! I was even thinking as I sent that off,
why does this compile on Ultrix, do we have those fields there?

Thanks/sorry

Donn Cave, University Computing Services, University of Washington
donn@u.washington.edu

Show quoted text
>Unformatted: