Ticket History #8888: compile failure on red hat 6

# Tue Mar 24 01:45:07 2020 Norm Green <norm.green@gemtalksystems.com> - Ticket created

From:	"Norm Green" <norm.green@gemtalksystems.com>
To:	krb5-bugs@mit.edu
Date:	Mon, 23 Mar 2020 22:16:35 -0700
Subject:	compile failure on red hat 6

Download (untitled) / with headers
text/plain 414B

In this file:

src/plugins/preauth/spake/edwards25519_fiat.h

The following code fails to compile on RH 6.5 (gcc 4.4)

typedef signed __int128 fiat_25519_int128;
typedef unsigned __int128 fiat_25519_uint128;

Changing the typedefs as follows appears to work on both old and newer
versions of gcc:

typedef __int128_t fiat_25519_int128;
typedef __uint128_t fiat_25519_uint128;

Norm Green
GemTalk Systems LLC

# Thu Mar 26 18:27:31 2020 ghudson@mit.edu (Greg Hudson) - Taken

# Thu Mar 26 18:27:31 2020 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'resolved'

# Thu Mar 26 18:27:31 2020 ghudson@mit.edu (Greg Hudson) - Target_Version 1.18-next added

# Thu Mar 26 18:27:31 2020 ghudson@mit.edu (Greg Hudson) - Target_Version 1.17-next added

# Thu Mar 26 18:27:31 2020 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Thu Mar 26 18:27:31 2020 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 554B

Make fiat 128-bit typedefs work with older gcc

Use the int128_t and uint128_t types defined by edwards25519.c, rather
than [un]signed __int128 which does not compile with gcc 4.4.
Reported by Norm Green.

https://github.com/krb5/krb5/commit/dd5d6e5e39be6cf7fe9d54a79e824f8cb7301177
Author: Greg Hudson <ghudson@mit.edu>
Commit: dd5d6e5e39be6cf7fe9d54a79e824f8cb7301177
Branch: master
src/plugins/preauth/spake/edwards25519.c | 4 +++-
src/plugins/preauth/spake/edwards25519_fiat.h | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)

# Fri Apr 10 13:14:30 2020 ghudson@mit.edu (Greg Hudson) - Target_Version 1.17-next deleted

# Fri Apr 10 15:06:57 2020 ghudson@mit.edu (Greg Hudson) - Version_Fixed 1.18.1 added

# Fri Apr 10 15:06:57 2020 ghudson@mit.edu (Greg Hudson) - Correspondence added

Subject:	git commit
From:	ghudson@mit.edu

Download (untitled) / with headers
text/plain 627B

Make fiat 128-bit typedefs work with older gcc

Use the int128_t and uint128_t types defined by edwards25519.c, rather
than [un]signed __int128 which does not compile with gcc 4.4.
Reported by Norm Green.

(cherry picked from commit dd5d6e5e39be6cf7fe9d54a79e824f8cb7301177)

https://github.com/krb5/krb5/commit/411366f9396d63147c4bc433aff42b9554d4d6be
Author: Greg Hudson <ghudson@mit.edu>
Commit: 411366f9396d63147c4bc433aff42b9554d4d6be
Branch: krb5-1.18
src/plugins/preauth/spake/edwards25519.c | 4 +++-
src/plugins/preauth/spake/edwards25519_fiat.h | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)

# Fri Apr 10 15:09:18 2020 ghudson@mit.edu (Greg Hudson) - Tags pullup deleted