Ticket History #954: /src/appl/bsd may not be complied for Linux 2.2.14 (Alpha)

From root@infern.eus.snu.ac.kr Sun May 13 08:35:32 2001
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.7.21.83])
by rt-11.mit.edu (8.9.3/8.9.3) with ESMTP id IAA01649
for <bugs@RT-11.mit.edu>; Sun, 13 May 2001 08:35:28 -0400 (EDT)
Received: from infern.eus.snu.ac.kr (infern.eus.snu.ac.kr [147.46.105.62])
by pacific-carrier-annex.mit.edu (8.9.2/8.9.2) with ESMTP id IAA13424
for <krb5-bugs@mit.edu>; Sun, 13 May 2001 08:35:27 -0400 (EDT)
Received: (from root@localhost)
by infern.eus.snu.ac.kr (8.9.3/8.9.3) id VAA31415;
Sun, 13 May 2001 21:33:35 +0900
Message-Id: <200105131233.VAA31415@infern.eus.snu.ac.kr>
Date: Sun, 13 May 2001 21:33:35 +0900
From: patria@enterprisent.com
Reply-To: patria@enterprisent.com
To: krb5-bugs@mit.edu
Subject: /src/appl/bsd may not be complied for Linux 2.2.14 (Alpha)
X-Send-Pr-Version: 3.99

Seoul National University
System: Linux infern 2.2.14-6.0 #1 Tue Mar 28 16:56:56 EST 2000 alpha unknown
Architecture: alpha

/src/appl/bsd/krlogin.c cannot be complied with egcs-2.91.66
on Linux 2.2.14-60 (alpha) machine.
Followings are output lines during make.

krlogin.c:788: variable `noltc' has initializer but incomplete type
krlogin.c:788: warning: excess elements in struct initializer after `noltc'
krlogin.c:788: warning: excess elements in struct initializer after `noltc'
krlogin.c:788: warning: excess elements in struct initializer after `noltc'
krlogin.c:788: warning: excess elements in struct initializer after `noltc'
krlogin.c:788: warning: excess elements in struct initializer after `noltc'
krlogin.c:788: warning: excess elements in struct initializer after `noltc'
krlogin.c: In function `doit':
krlogin.c:816: sizeof applied to an incomplete type
krlogin.c: In function `catchild':
krlogin.c:1028: warning: passing arg 2 of `waitpid' from incompatible pointer type
krlogin.c: In function `writer':
krlogin.c:1142: invalid use of undefined type `struct ltchars'
krlogin.c:1142: invalid use of undefined type `struct ltchars'
krlogin.c: In function `read_wrapper':
krlogin.c:1238: invalid use of undefined type `struct ltchars'
krlogin.c: In function `stop':
krlogin.c:1295: invalid use of undefined type `struct ltchars'
krlogin.c: In function `mode':
krlogin.c:1623: sizeof applied to an incomplete type
krlogin.c:1667: sizeof applied to an incomplete type
krlogin.c: At top level:
krlogin.c:787: storage size of `defltc' isn't known
make: *** [krlogin.o] Error 1

Excluding applications on this directory will be a workaround
for using Kerberos V.

Complier used is egcs-2.91.66.


Try 'make' from the directory, /src/appl/bsd, will generate errors.


Just I've skipped making bsd applications for Kerberos.

State-Changed-From-To: open-feedback
State-Changed-By: tlyu
State-Changed-When: Thu Oct 11 22:30:03 2001
State-Changed-Why:

sent probable patch pulled from trunk


From: Tom Yu <tlyu@MIT.EDU>
To: patria@enterprisent.com
Cc: krb5-bugs@MIT.EDU
Subject: Re: krb5-build/954: /src/appl/bsd may not be complied for Linux 2.2.14 (Alpha)
Date: Thu, 11 Oct 2001 22:29:59 -0400 (EDT)




[...]

Hi. I believe we may have already fixed this bug in our current
sources. Could you please tell us if the included patch against
krb5-1.2.2 fixes your problem?

---Tom

Index: krlogin.c
===================================================================
RCS file: /cvs/krbdev/krb5/src/appl/bsd/krlogin.c,v
retrieving revision 5.63.2.7
diff -c -r5.63.2.7 krlogin.c
*** krlogin.c 2001/01/26 05:14:55 5.63.2.7
--- krlogin.c 2001/10/12 02:28:01
***************
*** 138,149 ****
#endif
#endif

- /* how do we tell apart irix 5 and irix 4? */
- #if defined(__sgi) && defined(__mips)
- /* IRIX 5: TIOCGLTC doesn't actually work */
- #undef TIOCGLTC
- #endif
-
#ifndef TIOCPKT_NOSTOP
/* These values are over-the-wire protocol, *not* local values */
#define TIOCPKT_NOSTOP 0x10
--- 138,143 ----
***************
*** 774,779 ****
--- 768,775 ----
};
#endif

+
+ #ifndef POSIX_TERMIOS
#ifdef TIOCGLTC
/*
* POSIX 1003.1-1988 does not define a 'suspend' character.
***************
*** 787,800 ****
struct ltchars defltc;
struct ltchars noltc = { -1, -1, -1, -1, -1, -1 };
#endif
-
- #ifndef POSIX_TERMIOS
struct tchars deftc;
struct tchars notc = { -1, -1, -1, -1, -1, -1 };
- #ifndef TIOCGLTC
- struct ltchars defltc;
- struct ltchars noltc = { -1, -1, -1, -1, -1, -1 };
- #endif
#endif

doit(oldmask)
--- 783,790 ----
***************
*** 812,820 ****
/* there's a POSIX way of doing this, but do we need it general? */
deftty.c_cc[VLNEXT] = 0;
#endif
- #ifdef TIOCGLTC
- (void) ioctl(0, TIOCGLTC, (char *)&defltc);
- #endif
#else
#ifdef USE_TERMIO
struct termio sb;
--- 802,807 ----
***************
*** 1138,1151 ****
}
}

- #ifdef TIOCGLTC
- if ((c == defltc.t_suspc || c == defltc.t_dsuspc)
- && !no_local_escape) {
- echo(c);
- stop(c);
- continue;
- }
- #else
#ifdef POSIX_TERMIOS
if ( (
(c == deftty.c_cc[VSUSP])
--- 1125,1130 ----
***************
*** 1158,1165 ****
stop(c);
continue;
}
! #endif
#endif

if (c != cmdchar) {
rcmd_stream_write(rem, &cmdchar, 1, 0);
--- 1137,1153 ----
stop(c);
continue;
}
! #else /*POSIX_TERMIOS*/
! #ifdef TIOCGLTC
! if ((c == defltc.t_suspc || c == defltc.t_dsuspc)
! && !no_local_escape) {
! echo(c);
! stop(c);
! continue;
! }
! #endif /*TIOCGLTC*/
#endif
+

if (c != cmdchar) {
rcmd_stream_write(rem, &cmdchar, 1, 0);
***************
*** 1233,1242 ****
bol = (c == deftty.c_cc[VKILL] ||
c == deftty.c_cc[VINTR] ||
c == '\r' || c == '\n');
- #ifdef TIOCGLTC
- if (!bol)
- bol = (c == defltc.t_suspc);
- #endif

#else /* !POSIX_TERMIOS */
bol = c == defkill || c == deftc.t_eofc ||
--- 1221,1226 ----
***************
*** 1291,1304 ****
(void) signal(SIGCHLD, SIG_IGN);
#endif

- #ifdef TIOCGLTC
- (void) kill(cmdc == defltc.t_suspc ? 0 : getpid(), SIGTSTP);
- #else
#ifdef POSIX_TERMIOS
(void) kill(cmdc == deftty.c_cc[VSUSP] ? 0 : getpid(), SIGTSTP);
#endif
#endif
-
#ifdef POSIX_SIGNALS
sa.sa_handler = catchild;
(void) sigaction(SIGCHLD, &sa, (struct sigaction *)0);
--- 1275,1287 ----
(void) signal(SIGCHLD, SIG_IGN);
#endif

#ifdef POSIX_TERMIOS
(void) kill(cmdc == deftty.c_cc[VSUSP] ? 0 : getpid(), SIGTSTP);
+ #else
+ #ifdef TIOCGLTC
+ (void) kill(cmdc == defltc.t_suspc ? 0 : getpid(), SIGTSTP);
#endif
#endif
#ifdef POSIX_SIGNALS
sa.sa_handler = catchild;
(void) sigaction(SIGCHLD, &sa, (struct sigaction *)0);
***************
*** 1618,1628 ****

switch(f) {
case 0:
- #ifdef TIOCGLTC
- #if !defined(sun)
- (void) ioctl(0, TIOCSLTC, (char *)&defltc);
- #endif
- #endif
(void) tcsetattr(0, TCSADRAIN, &deftty);
break;
case 1:
--- 1601,1606 ----
***************
*** 1659,1672 ****
newtty.c_cc[VMIN] = 1;
newtty.c_cc[VTIME] = 0;
(void) tcsetattr(0, TCSADRAIN, &newtty);
- #ifdef TIOCGLTC
- /* Do this after the tcsetattr() in case this version
- * of termio supports the VSUSP or VDSUSP characters */
- #if !defined(sun)
- /* this forces ICRNL under Solaris... */
- (void) ioctl(0, TIOCSLTC, (char *)&noltc);
- #endif
- #endif
break;
default:
return;
--- 1637,1642 ----

From: Tom Yu <tlyu@MIT.EDU>
To: krb5-bugs@MIT.EDU
Cc: Subject: Re: krb5-build/954: /src/appl/bsd may not be complied for Linux 2.2.14 (Alpha)
Date: Tue, 16 Oct 2001 22:58:12 -0400 (EDT)

Mail to originator bounces; patch will probably be queued for 1.2.3.