Skip Menu |
 

Download (untitled) / with headers
text/plain 2.8KiB
From b17783@atalanta.ctd.anl.gov Tue May 29 17:43:41 2001
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.7.21.83])
by rt-11.mit.edu (8.9.3/8.9.3) with ESMTP id RAA22392
for <bugs@RT-11.mit.edu>; Tue, 29 May 2001 17:43:41 -0400 (EDT)
Received: from atalanta.ctd.anl.gov (atalanta.ctd.anl.gov [146.137.64.60])
by pacific-carrier-annex.mit.edu (8.9.2/8.9.2) with ESMTP id RAA13242
for <krb5-bugs@mit.edu>; Tue, 29 May 2001 17:43:28 -0400 (EDT)
Received: from orleans.ctd.anl.gov (localhost [127.0.0.1])
by atalanta.ctd.anl.gov (8.9.1a/8.9.1) with ESMTP id QAA18007
for <krb5-bugs@mit.edu>; Tue, 29 May 2001 16:43:27 -0500 (CDT)
Received: (from b17783@localhost)
by orleans.ctd.anl.gov (8.9.3+Sun/8.9.1) id QAA07448;
Tue, 29 May 2001 16:43:27 -0500 (CDT)
Message-Id: <200105292143.QAA07448@orleans.ctd.anl.gov>
Date: Tue, 29 May 2001 16:43:27 -0500 (CDT)
From: Douglas Engert <b17783@achilles.ctd.anl.gov>
Reply-To: b17783@achilles.ctd.anl.gov
To: krb5-bugs@mit.edu
Subject: lib/crypto/sha1/shs.c fails on WIN32
X-Send-Pr-Version: 3.99

Show quoted text
>Number: 961
>Category: krb5-libs
>Synopsis: lib/crypto/sha1/shs.c fails on WIN32
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: raeburn
>State: feedback
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Tue May 29 17:44:00 EDT 2001
>Last-Modified: Thu Jul 5 21:14:09 EDT 2001
>Originator: Douglas Engert
>Organization:

Douglas E. Engert <DEEngert@anl.gov>
Argonne National Laboratory
9700 South Cass Avenue
Argonne, Illinois 60439
(630) 252-5444
Show quoted text
>Release: krb5-1.2.2
>Environment:
Win2000, using VC++ 6.0

Architecture: i386

Show quoted text
>Description:
The lib/crypto/sha1/shs.h needs a typedef for LONG
Without this the t_shs.exe fails.

Show quoted text
>How-To-Repeat:
Build the krb5-1.2.2 for Win32 from the unix source,
then build t_shs.exe program and run

Show quoted text
>Fix:
Adding : typedef unsigned int LONG; before the k5-int.h
fixes the probelm, and the t_shs.exe runs, as will as
GSS utilities and 3des keys.
There may be a better fix, as there is code at line 13 or so
which should deal with WIN32, but this appears to be to late.


*** ,shs.h Wed Feb 28 16:07:34 2001
--- shs.h Tue May 29 10:11:24 2001
***************
*** 1,5 ****
--- 1,9 ----
#ifndef _SHS_DEFINED

+ #if defined(_WIN32)
+ typedef unsigned int LONG;
+ #endif
+
#include <k5-int.h>

#define _SHS_DEFINED

Show quoted text
>Audit-Trail:

Responsible-Changed-From-To: krb5-unassigned->raeburn
Responsible-Changed-By: raeburn
Responsible-Changed-When: Thu Jul 5 21:12:34 2001
Responsible-Changed-Why:
3des

State-Changed-From-To: open-feedback
State-Changed-By: raeburn
State-Changed-When: Thu Jul 5 21:12:47 2001
State-Changed-Why:

Thanks. We wound up changing "LONG" to "SHS_LONG" and making the
typedef in shs.h unconditional. It seemed better not to have a
Windows-specific fix.

Show quoted text
>Unformatted: