Ticket History #999: default value thrown away in init

# Mon Aug 19 14:21:22 2002 The RT System itself - Default: Import/ changed from (no value) to (no value)

Download (untitled) / with headers
text/plain 3.1KiB

From ratliff@austin.ibm.com Mon Oct 1 18:19:44 2001
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.7.21.83])
by rt-11.mit.edu (8.9.3/8.9.3) with ESMTP id SAA00377
for <bugs@RT-11.mit.edu>; Mon, 1 Oct 2001 18:19:44 -0400 (EDT)
Received: from mg01.austin.ibm.com (mg01.austin.ibm.com [192.35.232.18])
by pacific-carrier-annex.mit.edu (8.9.2/8.9.2) with ESMTP id SAA01472
for <krb5-bugs@mit.edu>; Mon, 1 Oct 2001 18:19:44 -0400 (EDT)
Received: from austin.ibm.com (netmail.austin.ibm.com [9.3.7.137])
by mg01.austin.ibm.com (AIX4.3/8.9.3/8.9.3) with ESMTP id RAA24846
for <krb5-bugs@mit.edu>; Mon, 1 Oct 2001 17:21:05 -0500
Received: from spiff.austin.ibm.com (spiff.austin.ibm.com [9.53.216.123])
by austin.ibm.com (AIX4.3/8.9.3/8.9.3) with ESMTP id RAA31614
for <krb5-bugs@mit.edu>; Mon, 1 Oct 2001 17:19:42 -0500
Received: by spiff.austin.ibm.com (Postfix, from userid 501)
id 1B10D82C06; Mon, 1 Oct 2001 17:19:40 -0500 (CDT)
Message-Id: <20011001221940.1B10D82C06@spiff.austin.ibm.com>
Date: Mon, 1 Oct 2001 17:19:40 -0500 (CDT)
From: ratliff@austin.ibm.com
Reply-To: ratliff@austin.ibm.com
To: krb5-bugs@mit.edu, ratliff@austin.ibm.com
Subject: init_ctx error
X-Send-Pr-Version: 3.99

Show quoted text

>Number: 999
>Category: krb5-libs
>Synopsis: default value thrown away in init_ctx
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: raeburn
>State: feedback
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Mon Oct 1 18:20:00 EDT 2001
>Last-Modified: Tue Oct 9 23:57:28 EDT 2001
>Originator: Emily Ratliff
>Organization:

IBM Linux Technology Center, Security

Show quoted text

>Release: krb5-current
>Environment:

System: Linux spiff.austin.ibm.com 2.2.17-21mdk #1 Thu Oct 5 13:16:08 CEST 2000 i686 unknown
Architecture: i686

Show quoted text

>Description:

In init_common() in lib/krb5/krb/init_ctx.c there is a call to
profile_get_integer to get kdc_default_options with a default of
KDC_OPT_RENEWABLE_OK and the returned value stored in tmp.
The assignment on the next line assigns KDC_OPT_RENEWABLE_OK and
ignores the value returned in tmp. Either the call should be
removed or the returned value should be honored. Perhaps this
was a work-around, in which case it should be documented.

Show quoted text

>How-To-Repeat:

Look at code on lines 190-191 in lib/krb5/krb/init_ctx.c from
9/29's krb5-current.

Show quoted text

>Fix:

diff -ur src.old/lib/krb5/krb/init_ctx.c src/lib/krb5/krb/init_ctx.c
--- src.old/lib/krb5/krb/init_ctx.c Mon Oct 1 16:55:51 2001
+++ src/lib/krb5/krb/init_ctx.c Mon Oct 1 17:08:45 2001
@@ -190,7 +190,7 @@
profile_get_integer(ctx->profile, "libdefaults",
"kdc_default_options", 0,
KDC_OPT_RENEWABLE_OK, &tmp);
- ctx->kdc_default_options = KDC_OPT_RENEWABLE_OK;
+ ctx->kdc_default_options = tmp;
#ifdef macintosh
#define DEFAULT_KDC_TIMESYNC 1
#else

Show quoted text

>Audit-Trail:

Responsible-Changed-From-To: krb5-unassigned->raeburn
Responsible-Changed-By: raeburn
Responsible-Changed-When: Tue Oct 9 23:54:09 2001
Responsible-Changed-Why:
I'll take it...

State-Changed-From-To: open-feedback
State-Changed-By: raeburn
State-Changed-When: Tue Oct 9 23:57:07 2001
State-Changed-Why:

Thanks for catching this. It'll be fixed in 1.3.

Show quoted text

>Unformatted:

# Mon Aug 19 14:21:23 2002 The RT System itself - Component krb5-libs added

# Wed Sep 11 19:21:26 2002 tlyu (Taylor Yu) - Subject changed from 'default value thrown away in init_ctx ' to 'default value thrown away in init_ctx'

# Wed Sep 11 19:21:27 2002 tlyu (Taylor Yu) - Target_Version 1.3 added

# Wed Sep 11 19:21:48 2002 tlyu (Taylor Yu) - Status changed from 'stalled' to 'resolved'

# Wed Mar 12 20:53:46 2003 tlyu (Taylor Yu) - Version_Fixed 1.3 added

Ticket History #999: default value thrown away in init_ctx